Skip to content

remove deprecated author fields - #84997

Merged
fluttergithubbot merged 7 commits into
flutter:masterfrom
pq:deprecated_fields
Jun 22, 2021
Merged

remove deprecated author fields#84997
fluttergithubbot merged 7 commits into
flutter:masterfrom
pq:deprecated_fields

Conversation

@pq

@pq pq commented Jun 21, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Removes deprecated author field sections that will break on an upcoming SDK release.

See: https://dart-review.googlesource.com/c/sdk/+/204420

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jun 21, 2021
@google-cla google-cla Bot added the cla: yes label Jun 21, 2021
@pq
pq requested review from gspencergoog and jonahwilliams June 21, 2021 18:14
dnfield
dnfield approved these changes Jun 21, 2021
View reviewed changes

@dnfield dnfield left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot

fluttergithubbot commented Jun 22, 2021

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows tool_integration_tests_1_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot
fluttergithubbot merged commit 875b420 into flutter:master Jun 22, 2021
@pq
pq deleted the deprecated_fields branch June 22, 2021 13:06
@pq pq mentioned this pull request Jun 22, 2021
Merged
6 of 8 tasks
dart-bot pushed a commit to dart-lang/sdk that referenced this pull request Jun 22, 2021
@pq commit-bot@chromium.org
deprecated field pubspec diagnostic
5f21e93 
Corresponding analysis in the pub client: https://github.com/dart-lang/pub/blob/master/lib/src/validator/deprecated_fields.dart

Downstream Flutter repo fixes: flutter/flutter#84997


Change-Id: If453abcce3a24468e6fbcd2402e196000226fb4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204420
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog Awaiting requested review from gspencergoog
@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams
1 more reviewer
@dnfield dnfield dnfield approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pq @fluttergithubbot @dnfield