Repository navigation
Make scrollbar assertions less aggressive - #84809
Merged
Merged
Conversation
dnfield
reviewed
Jun 17, 2021
Contributor
|
I like the proposed changes. Delaying the assertion to when the scrollbar has been interacted with, will help a lot to tell which scrollbar in the tree is incorrect. The error in the gallery project was a bit confusing. |
Contributor
Author
This should only delay it until it is visible and available for interaction. :) |
dnfield
approved these changes
Jun 21, 2021
dnfield
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the example, really helpful
Lgtm
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
davidmartos96
pushed a commit
to davidmartos96/flutter
that referenced
this pull request
Jun 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adjusts the assertions on interactive scrollbars to only be applied when the scrollbar is visible.
Related issues:
This also adds more documentation and code samples. I cleaned up a bit, removing outstanding todos and fixing some abbreviations in the tests.
For some of the removed todos, I filed issues to actually track the feature requests. 🙃
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.