Skip to content

Remove "unnecessary" imports. - #82828

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
srawlins:private_test
May 19, 2021
Merged

fluttergithubbot merged 1 commit into
flutter:masterfrom
srawlins:private_test

Conversation

@srawlins

Copy link
Copy Markdown
Contributor

In each library where an import is removed, the library uses some elements
provided by the import, BUT there is another import which provides all of the
same elements, and at least one more which the library uses.

In this change, we remove the imports which can be simply removed in favor of
the other already present imports.

See dart-lang/sdk#44569 for more information.

List which issues are fixed by this PR. You must list at least one issue.

#74381 is improved by this issue. Not fixed.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

In each library where an import is removed, the library uses some elements
provided by the import, BUT there is another import which provides all of the
same elements, and at least one more which the library uses.

In this change, we remove the imports which can be simply removed in favor of
the other already present imports.

See dart-lang/sdk#44569 for more information.
@flutter-dashboard flutter-dashboard Bot added the framework flutter/packages/flutter repository. See also f: labels. label May 18, 2021
@google-cla google-cla Bot added the cla: yes label May 18, 2021
@srawlins

Copy link
Copy Markdown
Contributor Author

CI looks good

@srawlins

Copy link
Copy Markdown
Contributor Author

CC @jason-simmons

@srawlins

Copy link
Copy Markdown
Contributor Author

Thanks! Would you mind submitting, @jason-simmons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants