Skip to content

Remove redundant MediaQueryDatas in tests - #82348

Merged
fluttergithubbot merged 2 commits into
flutter:masterfrom
nt4f04uNd:ref
Jul 20, 2021
Merged

fluttergithubbot merged 2 commits into
flutter:masterfrom
nt4f04uNd:ref

Conversation

@nt4f04uNd

@nt4f04uNd nt4f04uNd commented May 12, 2021 •

Copy link
Copy Markdown
Member

MaterialApp provides MediaQueryData from window, no need to create one unless we change it

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels May 12, 2021
@google-cla google-cla Bot added the cla: yes label May 12, 2021
@flutter-dashboard

Copy link
Copy Markdown

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. labels Jun 10, 2021

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nt4f04uNd this is a great PR! LGTM! Thank you for cleaning up these tests. Can you rebase with master to bring this up to date? It looks like it has been a while and I'd hate for it to get reverted due to a change at TOT. Thanks!

@fluttergithubbot
fluttergithubbot merged commit d8cdaba into flutter:master Jul 20, 2021
@nt4f04uNd
nt4f04uNd deleted the ref branch September 16, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants