Repository navigation
Remove redundant MediaQueryDatas in tests - #82348
Merged
Merged
Conversation
HansMuller
self-requested a review
May 13, 2021 17:52
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Piinks
approved these changes
Jun 10, 2021
Piinks
left a comment
Contributor
There was a problem hiding this comment.
Hey @nt4f04uNd this is a great PR! LGTM! Thank you for cleaning up these tests. Can you rebase with master to bring this up to date? It looks like it has been a while and I'd hate for it to get reverted due to a change at TOT. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaterialApp provides MediaQueryData from window, no need to create one unless we change it
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.