Skip to content

Change elevation to double of MergeableMaterial - #81634

Merged
fluttergithubbot merged 2 commits into
flutter:masterfrom
Abhishek01039:elevation_MergeableMaterial
May 3, 2021
Merged

fluttergithubbot merged 2 commits into
flutter:masterfrom
Abhishek01039:elevation_MergeableMaterial

Conversation

@Abhishek01039

@Abhishek01039 Abhishek01039 commented May 2, 2021 •

Copy link
Copy Markdown
Contributor

Update elevation from int to double
Fixes #11468

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels May 2, 2021
@google-cla google-cla Bot added the cla: yes label May 2, 2021
@Abhishek01039

Abhishek01039 commented May 2, 2021 •

Copy link
Copy Markdown
Contributor Author

Hello @Hixie
can you please review this PR?
Thanks

@Hixie

Hixie commented May 2, 2021

Copy link
Copy Markdown
Contributor

test-exempt: code refactor

Please don't forget to update the commit message above.

There's a bunch of places in this file that use "toDouble" that should now be redundant. We should remove those as well. (@a14n: might be worth a lint -- flagging cases where one has used toDouble() on a type we know statically to be a double, and similar, e.g. .round() on an int, or .toString() on a String)

If this lands successfully, we should also consider doing the next one up the chain, ExpansionPanel.

@Abhishek01039

Copy link
Copy Markdown
Contributor Author

Thanks @Hixie
I have removed those and updated the commit message

@Hixie Hixie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the tests pass! (The Google Testing ones are the ones I'm mostly concerned about...)

@Abhishek01039

Abhishek01039 commented May 2, 2021 •

Copy link
Copy Markdown
Contributor Author

Hey @Hixie
I have seen you in one of the boring flutter show
you are good tutor as well as Engineer
thanks for your hard work because I can see today is your holiday still you are doing work for make flutter better!

@thecalamiity

thecalamiity commented May 2, 2021 •

Copy link
Copy Markdown
Contributor

Why the .toDouble() for the expansion tile?

@thecalamiity

thecalamiity commented May 2, 2021 •

Copy link
Copy Markdown
Contributor

Also this probably fixes #11468

@Abhishek01039

Copy link
Copy Markdown
Contributor Author

hello @mrbirb
because expansion tile has final int elevation;

@Hixie

Hixie commented May 3, 2021

Copy link
Copy Markdown
Contributor

we should file a bug about ExpansionPanelList using int for elevation now too

@Abhishek01039

Copy link
Copy Markdown
Contributor Author

Sure @Hixie
And please assign to me!
Thanks

@fluttergithubbot
fluttergithubbot merged commit 74d403a into flutter:master May 3, 2021
@Hixie

Hixie commented May 3, 2021

Copy link
Copy Markdown
Contributor

By "we" I meant "you", really. :-)

@Abhishek01039
Abhishek01039 deleted the elevation_MergeableMaterial branch May 4, 2021 05:27
@Abhishek01039

Copy link
Copy Markdown
Contributor Author

Great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MergeableMaterial should express elevation as a double not as an int

4 participants