Skip to content

[flutter_tools] skip additional flaky test - #81555

Merged
fluttergithubbot merged 2 commits into
flutter:masterfrom
jonahwilliams:skip_overall_experience_test
May 1, 2021
Merged

fluttergithubbot merged 2 commits into
flutter:masterfrom
jonahwilliams:skip_overall_experience_test

Conversation

@jonahwilliams

Copy link
Copy Markdown
Contributor

This one is also flaking, but only on Windows CI

@flutter-dashboard flutter-dashboard Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 30, 2021
@google-cla google-cla Bot added the cla: yes label Apr 30, 2021
tryToDelete(fileSystem.directory(tempDirectory));
}
});
}, skip: Platform.isWindows); // TODO(goderbauer): Re-enable when this test is reliable on device lab, https://github.com/flutter/flutter/issues/81486

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#81486 is devtools specific, this doesn't appear to fail because of devtools?

Also, wanna use your name in the TODO 😝 ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer

Copy link
Copy Markdown
Member

Issue: #81556

@fluttergithubbot

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants