Repository navigation
[flutter_tools] remove mocks from clean test - #81311
Merged
jonahwilliams merged 3 commits intoApr 27, 2021
Merged
jonahwilliams merged 3 commits into
jonahwilliams merged 3 commits into
Conversation
flutter-dashboard
Bot
added
the
tool
jmagman
approved these changes
Apr 27, 2021
jmagman
left a comment
jmagman
left a comment
Member
There was a problem hiding this comment.
LGTM with mockXcodeProjectInterpreter->fakeXcodeProjectInterpreter nit
| return projectUnderTest; | ||
| } | ||
|
|
||
| class MockXcodeProjectInterpreter extends Fake implements XcodeProjectInterpreter { |
added 2 commits
April 27, 2021 11:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #71511
Remove mocks from clean command test. Replace test which threw error on exists to one that throws an error on delete.