Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo Removed accentColor dependency from ExpansionTile #79829

Conversation

HansMuller
Copy link
Contributor

The icon and title text color for expanded tiles is now the overall theme's ColorScheme.secondary color instead of the theme's accentColor. This PR removes the widget's accentColor dependency per #56918.

This PR re-lands #77933.

Depends on internal Google changes: cl/366838968 (tested and approved in cl/366508055).

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 6, 2021
@google-cla google-cla bot added the cla: yes label Apr 6, 2021
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 6b581c4 into flutter:master Apr 6, 2021
@HansMuller HansMuller deleted the redo_remove_accent_color_in_expansion_tile branch April 6, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants