Skip to content

Conversation

@goderbauer
Copy link
Member

fixes #7654

@goderbauer
Copy link
Member Author

/cc @devoncarew

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? this seems like a net loss.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows's cmd cannot print Unicode characters reliably. Why is this a net loss? It's the same Information, just a different separator character?

New:

  Nexus 6P - 84B5T15A10012703 - android-arm - Android 7.1.1 (API 25)

Old:

Nexus 6P • 84B5T15A10012703 • android-arm • Android 7.1.1 (API 25)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter is all-in on using the prettiest and most awesomest Unicode in its messages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use different separator chars based on the OS (pretty on non-windows; functional on windows).

@Hixie
Copy link
Contributor

Hixie commented Jan 27, 2017

Is Windows not UTF-8 capable?

@goderbauer
Copy link
Member Author

You can programmatically switch cmd's code page to UTF-8. However there is one big problem with that: There is no good way to switch the code page back to the default. Programs that run after flutter (e.g. git status) will assume the default code page and now produce garbage output in UTF-8 mode. It's a mess.

@Hixie
Copy link
Contributor

Hixie commented Jan 27, 2017

RSLGTM

@Hixie
Copy link
Contributor

Hixie commented Jan 27, 2017

After discussion we decided to remove the special-casing for Windows for now, and we'll have a WindowsTerminal one day that filters out Unicode and says supportsColor=false and suchlike.

@Hixie
Copy link
Contributor

Hixie commented Jan 27, 2017

(The problem is that the framework outputs Unicode all the time. Imagine hooking up an Android device that had logged output and then running flutter logs. You want the logs to be readable.)

@goderbauer goderbauer merged commit c234d40 into flutter:master Jan 28, 2017
@goderbauer goderbauer deleted the batScript branch January 28, 2017 07:12
@goderbauer goderbauer added the platform-windows Building on or for Windows specifically label Oct 17, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-windows Building on or for Windows specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flutter.ps1 script not found when run from the regular command prompt

4 participants