-
Notifications
You must be signed in to change notification settings - Fork 29.6k
Replace bin/flutter.ps1 with bin/flutter.bat #7713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/cc @devoncarew |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? this seems like a net loss.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows's cmd cannot print Unicode characters reliably. Why is this a net loss? It's the same Information, just a different separator character?
New:
Nexus 6P - 84B5T15A10012703 - android-arm - Android 7.1.1 (API 25)Old:
Nexus 6P • 84B5T15A10012703 • android-arm • Android 7.1.1 (API 25)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flutter is all-in on using the prettiest and most awesomest Unicode in its messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could use different separator chars based on the OS (pretty on non-windows; functional on windows).
|
Is Windows not UTF-8 capable? |
|
You can programmatically switch cmd's code page to UTF-8. However there is one big problem with that: There is no good way to switch the code page back to the default. Programs that run after flutter (e.g. git status) will assume the default code page and now produce garbage output in UTF-8 mode. It's a mess. |
|
After discussion we decided to remove the special-casing for Windows for now, and we'll have a WindowsTerminal one day that filters out Unicode and says supportsColor=false and suchlike. |
|
(The problem is that the framework outputs Unicode all the time. Imagine hooking up an Android device that had logged output and then running |

fixes #7654