Skip to content

Revert "prevent pageView scrolling when calling ensureVisible" #68036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2020
Merged

Revert "prevent pageView scrolling when calling ensureVisible" #68036

merged 1 commit into from
Oct 13, 2020

Conversation

jonahwilliams
Copy link
Contributor

Reverts #67988

This is causing the new gallery task to fail via timeout

FYI @zanderso @godofredoc

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 13, 2020
@google-cla google-cla bot added the cla: yes label Oct 13, 2020
@jonahwilliams jonahwilliams merged commit 37ebe3d into master Oct 13, 2020
@jonahwilliams jonahwilliams deleted the revert-67988-ensure1013 branch October 13, 2020 17:52
@xu-baolin
Copy link
Member

@jonahwilliams Hi,
Sorry to notice this revert so late, is there any more information about the failure? Thanks!
cc @dnfield

@xu-baolin xu-baolin mentioned this pull request Jan 5, 2021
Open
@xu-baolin xu-baolin mentioned this pull request Jan 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonahwilliams @xu-baolin