Skip to content

Transport e2e based perforamnce test to integration_test and remove duplicate watchPerformance #67594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2020
Merged

Transport e2e based perforamnce test to integration_test and remove duplicate watchPerformance #67594

merged 3 commits into from
Oct 18, 2020

Conversation

CareF
Copy link
Contributor

@CareF CareF commented Oct 8, 2020

Description

This is NOT a complete upgrade from the e2e dependence in the framework to integration_test but just those that reference watchPerformance.

Related Issues

Fixes #63537

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@CareF CareF requested review from dnfield and liyuqian October 8, 2020 01:43
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Oct 8, 2020
@google-cla google-cla bot added the cla: yes label Oct 8, 2020
@CareF
Copy link
Contributor Author

CareF commented Oct 8, 2020

The CI will fail until flutter/plugins#3116 is merged and published to pub.dev

@liyuqian
Copy link
Contributor

liyuqian commented Oct 9, 2020

@CareF : integration_test 0.9.2 has been published. Can you please rerun the presubmit tests?

@CareF
Copy link
Contributor Author

CareF commented Oct 10, 2020

@CareF : integration_test 0.9.2 has been published. Can you please rerun the presubmit tests?

@liyuqian Test completed.

Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac plugin_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac framework_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[e2e] Move watchPerformance to e2e after FrameTimingSummarizer goes into stable release
3 participants