Update to the latest localizations - Adds missing DatePicker strings and fixes manually entering date for German#63026
Merged
fluttergithubbot merged 9 commits intoflutter:masterfrom Aug 6, 2020
shihaohong:de_localizations
Merged
Update to the latest localizations - Adds missing DatePicker strings and fixes manually entering date for German#63026fluttergithubbot merged 9 commits intoflutter:masterfrom shihaohong:de_localizations
fluttergithubbot merged 9 commits intoflutter:masterfrom
shihaohong:de_localizations
Conversation
flutter-dashboard
bot
added
a: internationalization
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
shihaohong
added
f: cupertino
HansMuller
approved these changes
Aug 6, 2020
Contributor
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
LGTM without the _nb stuff for now.
Contributor
Author
|
Removed |
13 tasks
13 tasks
shihaohong
changed the title
|
removing cp label in favor of #55535 |
pcsosinski
pushed a commit
that referenced
this pull request
Aug 13, 2020
* Fix SliverList scrollOffsetCorrection 0 case (#62615) * Case insensitive check flavor names against Xcode schemes (#61140) * Address misc time picker design issues (#62803) * Update to the latest localizations (#63026) * Removed the inputFormatters from the text input fields used by the Date Pickers (#63461) * Fix App.framework path in Podfile (#63412) * Update engine hash to 1.20.2 Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Jenn Magder <magder@google.com> Co-authored-by: Rami <2364772+rami-a@users.noreply.github.com> Co-authored-by: Shi-Hao Hong <shihaohong@google.com> Co-authored-by: Darren Austin <darrenaustin@google.com>
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continues on #62896, since @rami-a may have internet connectivity issues over the next day or so.
Updates the translated strings in the Flutter project.
Oddness with
_nbfiles:Edit: It seems that the internal translation console now generates both
_nb.arband_no.arbfiles. In that case, we should keep both versions to keep things consistent with the translation console. Given this change, we should be able to remove the workaround that makes_no.arband_nb.arbsynonyms in the framework code, but I'll do it in a separate PR to make sure that after removing the code, everything continues to work as expected.Somehow,
_nb.arbfiles are now also added by Google's internal translation console alongside_no.arb. I'll need to see if this is expected, as it may be a new update to how these are generated (we currently generate_nb.dartsource files through duplicating_no.arb's messages, so it's quite odd that_nb.arbfiles are being generated).Another oddity is that the_nb.arbtranslations seem incomplete on the translation console. For this PR, I just manually removed the_nb.arbsource files, but this inconsistency needs to be investigated.Related Issues
Fixes #55535
Tests
I added the following tests:
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.