Skip to content

[flutter_tools] revert dart format changes#61760

Merged
fluttergithubbot merged 3 commits intoflutter:masterfrom
jonahwilliams:revert_dfmt
Jul 20, 2020
Merged

[flutter_tools] revert dart format changes#61760
fluttergithubbot merged 3 commits intoflutter:masterfrom
jonahwilliams:revert_dfmt

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Jul 17, 2020

Description

Revert to invocation of dartfmt snapshot instead of dartdev tool

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 17, 2020
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Jul 17, 2020

@pcsosinski @zanderso

@pcsosinski
Copy link

pcsosinski commented Jul 17, 2020

we should only land this on 1.20

@jonahwilliams jonahwilliams requested a review from zanderso July 17, 2020 19:23
zanderso
zanderso approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! lgtm

@fluttergithubbot fluttergithubbot merged commit 78a9754 into flutter:master Jul 20, 2020
@jonahwilliams jonahwilliams deleted the revert_dfmt branch July 20, 2020 16:32
@jonahwilliams jonahwilliams mentioned this pull request Jul 20, 2020
Closed
@guidezpl guidezpl mentioned this pull request Jul 21, 2020
Merged
pcsosinski pushed a commit to pcsosinski/flutter that referenced this pull request Jul 28, 2020
[flutter_tools] revert dart format changes (flutter#61760)
9820a24
@pcsosinski pcsosinski mentioned this pull request Jul 28, 2020
Merged
pcsosinski pushed a commit that referenced this pull request Jul 28, 2020
@jmagman
1.20.0-7.3.pre beta cherrypicks (#62444)
e606910 
* Update engine hash to 1.20.0-7.3.pre

* [flutter_tools] revert dart format changes (#61760)

* Allow hyphens in iOS UDIDs (#62225)

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
Co-authored-by: Jenn Magder <magder@google.com>
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
@Pragya007
[flutter_tools] revert dart format changes (flutter#61760)
60904dd
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@mingwandroid
[flutter_tools] revert dart format changes (flutter#61760)
6440cdc
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso zanderso approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jonahwilliams @pcsosinski @zanderso @googlebot @fluttergithubbot