Add support for leading parameter in TextStyle #24637
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryQian
added
work in progress; do not review
a: typography
zoechi
added
the
framework
Hixie
reviewed
Dec 11, 2018
| @@ -313,13 +314,20 @@ class TextStyle extends Diagnosticable { | |||
| /// parent text span, or, for the root text spans, with the line box. | |||
| final TextBaseline textBaseline; | |||
|
|
|||
| /// The height of this text span, as a multiple of the font size. | |||
| /// The height of this text span, as a multiple of the sum of font size and leading. | |||
| /// | |||
| /// If applied to the root [TextSpan], this value sets the line height, which | |||
| /// is the minimum distance between subsequent text baselines, as multiple of | |||
| /// the font size. | |||
There was a problem hiding this comment.
either font size and leading or font size (the root [TextSpan] ignores the [leading])
Hixie
reviewed
Dec 11, 2018
| /// | ||
| /// When null, default font leading will be used. Leading is the additional | ||
| /// spacing between lines. | ||
| final double leading; |
There was a problem hiding this comment.
this should mention that it's ignored at the paragraph level
|
This is now waiting for the engine-side to land and roll. Will require a manual roll. |
|
Holding off on this change, as we will be implementing the 'Strut' system that will allow finer control of line spacing. |
|
This will be superseded by the changes in flutter/engine#7414 and #26085. It is possible that this feature can be landed alongside it, but that will be attempted later after strut is landed and stable as it provides much but not all of the functionality of this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables leading as a TextStyle parameter to non-breaking-ly allow users to adjust the line spacing without changing the overall height of the text span and the metrics surrounding it.
Requires an engine roll with the LibTxt changes.
See #23875.