Add some a basic debug stepping tests #24515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Dec 11, 2018
|
|
||
| import 'project.dart'; | ||
|
|
||
| class SteppingProject extends Project { |
Contributor
There was a problem hiding this comment.
run dartfmt (as this is a new file)?
Contributor
Author
There was a problem hiding this comment.
Done! The only change was removing one blank line (which I guess is what you'd noticed). Thanks!
zoechi
added
the
tool
Hixie
reviewed
Dec 14, 2018
| await _flutter.run(withDebugger: true); | ||
|
|
||
| // Stop at the initial breakpoint that the expected steps are based on. | ||
| await _flutter.breakAt(_project.breakpointUri, _project.breakpointLine, restart: true); |
Contributor
There was a problem hiding this comment.
i'm changing this in my PR to start the app paused, set the breakpoint, resume, then wait for it to hit the breakpoint. This avoids the need for the restart.
Contributor
Author
There was a problem hiding this comment.
Sounds reasonable to me :-)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A re-take of #18878. This adds a test that hits a breakpoint and then steps over some
awaits and ensures we step to the correct locations. This was added because we had issues with this previously (#18877).