Eliminate snapshot/depfile options to build bundle #21507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Sep 6, 2018
|
I realise I deleted the --depfile param from Xcode but not Gradle in the original PR here. I'll update this PR with the cleanup I mentioned above. |
cbracken
changed the title
cbracken
force-pushed
the
kill-snapshot_blob.bin-refs
branch
2 times, most recently
from
6ea6faf
to
270a769
Compare
The --snapshot argument was only necessary in Dart 1. The --depfile argument was only used in Dart 2 mode to pass to the kernel compiler, but was inconsistent with the 'build aot' command, where the depfile was always set to build/kernel_compile.d. This patch updates 'build bundle' to emit the depfile to a location consistent with the 'build aot' command; since it's not intended to be user-configurable and flutter.gradle hardcodes the location to build/kernel_compile.d either way, this patch also eliminates the ability to configure the filename altogether.
cbracken
force-pushed
the
kill-snapshot_blob.bin-refs
branch
from
bda9697
to
abbf711
Compare
cbracken
changed the title
|
Done. |
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Sep 7, 2018
…1507)" This tickled a bug in KernelCompiler.compile() where the fingerprinter doesn't include the outputFilePath in its list of dependencies. As such, if the output .dill file is missing or corrupted, the fingerprint still matches and re-compile is skipped, even though it shouldn't be. I'll fix that in a followup, then look at how this triggered that issue. My hypothesis is that that it's due to the aot kernel compile and bundle kernel compile have separate output directories for the .dill files (build/ vs build/aot) but the same output directory for the associated depfiles (due to this patch). This reverts commit 43a106e.
cbracken
added a commit
that referenced
this pull request
Sep 7, 2018
…21563) This tickled a bug in KernelCompiler.compile() where the fingerprinter doesn't include the outputFilePath in its list of dependencies. As such, if the output .dill file is missing or corrupted, the fingerprint still matches and re-compile is skipped, even though it shouldn't be. I'll fix that in a followup, then look at how this triggered that issue. My hypothesis is that that it's due to the aot kernel compile and bundle kernel compile have separate output directories for the .dill files (build/ vs build/aot) but the same output directory for the associated depfiles (due to this patch). This reverts commit 43a106e.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --snapshot argument was only necessary in Dart 1. The --depfile
argument was only used in Dart 2 mode to pass to the kernel compiler,
but was inconsistent with the 'build aot' command, where the depfile was
always set to build/kernel_compile.d.
This patch updates 'build bundle' to emit the depfile to a location
consistent with the 'build aot' command; since it's not intended to be
user-configurable and flutter.gradle hardcodes the location to
build/kernel_compile.d either way, this patch also eliminates the
ability to configure the filename altogether.