Skip to content

Add golden test for InkWell clipping #20750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2018
Merged

Add golden test for InkWell clipping #20750

merged 1 commit into from
Aug 20, 2018

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Aug 17, 2018

For #20483

@liyuqian liyuqian mentioned this pull request Aug 17, 2018
Closed
@liyuqian
Copy link
Contributor Author

liyuqian commented Aug 20, 2018

@jonahwilliams here's a duck sized horse 🦆

jonahwilliams
jonahwilliams approved these changes Aug 20, 2018
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay,

LGTM!

@liyuqian liyuqian merged commit 980c8a7 into flutter:master Aug 20, 2018
@liyuqian liyuqian deleted the inkgold branch August 27, 2018 23:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@HansMuller HansMuller Awaiting requested review from HansMuller

@Hixie Hixie Awaiting requested review from Hixie

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liyuqian @jonahwilliams @googlebot