Skip to content

[Android] Fix --merged-platform-ui-thread flag - #193901

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
camsim99:fix-merged-platform-ui-thread-flag
Oct 7, 2026
Merged

auto-submit[bot] merged 1 commit into
flutter:masterfrom
camsim99:fix-merged-platform-ui-thread-flag

Conversation

@camsim99

@camsim99 camsim99 commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Specify that the --merged-platform-ui-thread flag can take an argument in the embedding so that it can be set from the manifest (setting via the command line words with or without this PR).

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@camsim99
camsim99 requested a review from a team as a code owner October 6, 2026 12:06
@camsim99
camsim99 requested review from mboetger and removed request for a team October 6, 2026 12:06
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Oct 6, 2026
@github-actions github-actions Bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. team-android Owned by Android platform team labels Oct 6, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the --merged-platform-ui-thread flag definition in FlutterEngineFlags.java to require an explicit value (appending =), and updates the Javadoc to document that it accepts enabled or mergeAfterLaunch. It also updates existing tests and adds new test cases in FlutterLoaderTest.java to verify the correct parsing and passing of this flag with its values from manifest metadata in both debug and release modes. There are no review comments, and I have no feedback to provide.

@camsim99
camsim99 requested a review from jesswrd October 6, 2026 19:21
@jesswrd jesswrd added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 6, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Oct 7, 2026
Merged via the queue into flutter:master with commit b94e204 Oct 7, 2026
39 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD engine flutter/engine related. See also e: labels. platform-android Android applications specifically team-android Owned by Android platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants