Skip to content

Conversation

@ahmedsameha1
Copy link
Contributor

This is my attempt to handle #6537 for the CupertinoRadio widget.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Dec 3, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a regression test to ensure CupertinoRadio doesn't crash when rendered in a zero-sized area. The added test is good, but it only covers the light mode, unselected, and disabled state. The original issue was likely related to gradients used in dark mode, so I've suggested expanding the test to cover dark mode and selected states to make it more robust and prevent future regressions in those cases.

Comment on lines +966 to +973
testWidgets('CupertinoRadio does not crash at zero area', (WidgetTester tester) async {
await tester.pumpWidget(
const CupertinoApp(
home: Center(child: SizedBox.shrink(child: CupertinoRadio<bool>(value: false))),
),
);
expect(tester.getSize(find.byType(CupertinoRadio<bool>)), Size.zero);
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The added test is a good start, but it only covers the case of an unselected, disabled radio in light mode. The crash was likely related to drawing gradients, which happens in dark mode. To make this test more comprehensive and prevent future regressions, it should also cover dark mode for both selected and unselected states.

  testWidgets('CupertinoRadio does not crash at zero area', (WidgetTester tester) async {
    // Unselected, disabled, light mode.
    await tester.pumpWidget(
      const CupertinoApp(
        home: Center(child: SizedBox.shrink(child: CupertinoRadio<bool>(value: false))),
      ),
    );
    expect(tester.getSize(find.byType(CupertinoRadio<bool>)), Size.zero);

    // Unselected, disabled, dark mode.
    await tester.pumpWidget(
      const CupertinoApp(
        theme: CupertinoThemeData(brightness: Brightness.dark),
        home: Center(child: SizedBox.shrink(child: CupertinoRadio<bool>(value: false))),
      ),
    );
    expect(tester.getSize(find.byType(CupertinoRadio<bool>)), Size.zero);

    // Selected, disabled, dark mode.
    await tester.pumpWidget(
      const CupertinoApp(
        theme: CupertinoThemeData(brightness: Brightness.dark),
        home: Center(child: SizedBox.shrink(child: CupertinoRadio<bool>(value: false, groupValue: false))),
      ),
    );
    expect(tester.getSize(find.byType(CupertinoRadio<bool>)), Size.zero);
  });

@victorsanni victorsanni requested a review from dkwingsmt December 4, 2025 18:33
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist:

  • The test is in the correct file
  • The test name goes “does not crash at zero area”
  • The target widget is wrapped by Center (or is fullscreen)
  • The target widget does not have an overlay, or the overlay is tested
  • The target widget is expected to have a size of exactly Size.zero

@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 5, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Dec 5, 2025
Merged via the queue into flutter:master with commit 0951f1e Dec 6, 2025
71 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 8, 2025
Roll Flutter from 5b8720312a94 to b2de367c41e0 (38 revisions)

flutter/flutter@5b87203...b2de367

2025-12-08 engine-flutter-autoroll@skia.org Roll Packages from b17d3ff to 33a9a81 (3 revisions) (flutter/flutter#179579)
2025-12-08 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from XCoAHsnYnKrvuWU2o... to _pSztGZvEA3-Ry-GW... (flutter/flutter#179575)
2025-12-08 matt.kosarek@canonical.com Implementation of `TestWindowingOwner` for testing multi-window (flutter/flutter#179355)
2025-12-08 engine-flutter-autoroll@skia.org Roll Dart SDK from 11efe37089a7 to 75899721aa42 (2 revisions) (flutter/flutter#179573)
2025-12-08 engine-flutter-autoroll@skia.org Roll Skia from 0c016e4aefd5 to b1936c760645 (8 revisions) (flutter/flutter#179568)
2025-12-08 engine-flutter-autoroll@skia.org Roll Skia from 3c5f9e0c9269 to 0c016e4aefd5 (1 revision) (flutter/flutter#179565)
2025-12-08 engine-flutter-autoroll@skia.org Roll Dart SDK from 1a6c6f6398af to 11efe37089a7 (1 revision) (flutter/flutter#179564)
2025-12-07 engine-flutter-autoroll@skia.org Roll Skia from 4830855b6f84 to 3c5f9e0c9269 (1 revision) (flutter/flutter#179561)
2025-12-07 engine-flutter-autoroll@skia.org Roll Skia from d5a6b6af6d12 to 4830855b6f84 (1 revision) (flutter/flutter#179557)
2025-12-07 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from KilaJW3p3J_0yUDtV... to XCoAHsnYnKrvuWU2o... (flutter/flutter#179551)
2025-12-06 engine-flutter-autoroll@skia.org Roll Skia from 33b32cecb287 to d5a6b6af6d12 (1 revision) (flutter/flutter#179540)
2025-12-06 engine-flutter-autoroll@skia.org Roll Dart SDK from ea201dd2ef12 to 1a6c6f6398af (1 revision) (flutter/flutter#179539)
2025-12-06 engine-flutter-autoroll@skia.org Roll Dart SDK from d1d30ee8d5a0 to ea201dd2ef12 (1 revision) (flutter/flutter#179537)
2025-12-06 engine-flutter-autoroll@skia.org Roll Dart SDK from 30c906aa00f2 to d1d30ee8d5a0 (1 revision) (flutter/flutter#179534)
2025-12-06 engine-flutter-autoroll@skia.org Roll Skia from dccd48c6c6ab to 33b32cecb287 (2 revisions) (flutter/flutter#179531)
2025-12-06 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vDeTl_KBeLJY8nCAx... to KilaJW3p3J_0yUDtV... (flutter/flutter#179530)
2025-12-06 engine-flutter-autoroll@skia.org Roll Dart SDK from f3690c23d422 to 30c906aa00f2 (2 revisions) (flutter/flutter#179529)
2025-12-06 engine-flutter-autoroll@skia.org Roll Skia from e19670f70406 to dccd48c6c6ab (6 revisions) (flutter/flutter#179524)
2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoFormRow doesn't crash in 0x0 environment (flutter/flutter#178979)
2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoContextMenuAction doesn't crash in 0x0 envi… (flutter/flutter#178721)
2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoRadio doesn't crash in 0x0 environment (flutter/flutter#179378)
2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoSearchTextField doesn't crash in 0x0 enviro… (flutter/flutter#179487)
2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoPicker doesn't crash in 0x0 environment (flutter/flutter#179258)
2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoAlertDialog doesn't crash in 0x0 environment (flutter/flutter#178858)
2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoListTileChevron doesn't crash in 0x0 enviro… (flutter/flutter#179165)
2025-12-05 ahmedsameha1@gmail.com Make sure that CupertinoNavigationBar doesn't crash in 0x0 environment (flutter/flutter#179235)
2025-12-05 ahmedsameha1@gmail.com Replace dropdown button with dropdown menu (flutter/flutter#179095)
2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoCheckbox doesn't crash in 0x0 environment (flutter/flutter#178630)
2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoApp doesn't crash in 0x0 environment (flutter/flutter#178610)
2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoButton doesn't crash in 0x0 environment (flutter/flutter#178629)
2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoTimerPicker doesn't crash in 0x0 environment (flutter/flutter#178857)
2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoScrollbar doesn't crash in 0x0 environment (flutter/flutter#179442)
2025-12-05 engine-flutter-autoroll@skia.org Roll Dart SDK from 0fcab487446d to f3690c23d422 (1 revision) (flutter/flutter#179517)
2025-12-05 bruno.leroux@gmail.com Update several comments related to theme normalization (flutter/flutter#179457)
2025-12-05 ttankkeo112@gmail.com Reimplemented StretchingOverscrollIndicator with Simulation ported from Android 12. (flutter/flutter#173849)
2025-12-05 engine-flutter-autoroll@skia.org Roll Skia from a31411879251 to e19670f70406 (1 revision) (flutter/flutter#179511)
2025-12-05 codefu@google.com chore: mark tests as flaky (flutter/flutter#179518)
2025-12-05 engine-flutter-autoroll@skia.org Roll Dart SDK from 42fe3327abca to 0fcab487446d (3 revisions) (flutter/flutter#179506)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
...
reidbaker pushed a commit to AbdeMohlbi/flutter that referenced this pull request Dec 10, 2025
…tter#179378)

This is my attempt to handle
flutter#6537 for the CupertinoRadio
widget.

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants