remove unnecessary virtual destructor from VertexDescriptor

[planetmarshall]

virtual qualifier on VertexDescriptor descriptor is unnecessary as the class is final, and raises -Wunnecessary-virtual-specifier in Clang 21.1.0+

Closes #178681

Pre-launch Checklist

• I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
• I read the [Tree Hygiene] wiki page, which explains my responsibilities.
• I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
• I signed the [CLA].
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is [test-exempt].
• I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
• All existing and new tests are passing.

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

[gemini-code-assist]

Code Review

This pull request removes the unnecessary virtual specifier from the VertexDescriptor destructor, given that the class is marked as final. This change resolves a -Wunnecessary-virtual-specifier compiler warning. I have included one suggestion to address a misleading comment adjacent to the change for improved maintainability.

[gemini-code-assist]

While you're making this change, the comment on the preceding line (// |Comparable<PipelineVertexDescriptor>|) appears to be incorrect and could be removed. The destructor is not part of the Comparable interface. Additionally, the comment refers to PipelineVertexDescriptor instead of VertexDescriptor, which is what the class actually inherits from.

[chinmaygarde]

Good comment gem gem.

[chinmaygarde]

lgtm. The gemini review is sound though!

[auto-submit]

autosubmit label was removed for flutter/flutter/178682, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

[auto-submit]

autosubmit label was removed for flutter/flutter/178682, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.