Skip to content

Conversation

@AbdeMohlbi
Copy link
Contributor

@AbdeMohlbi AbdeMohlbi commented Nov 15, 2025

before :

 if (isPointerEvent && isMovementEvent) {
      // Continue.
    } else {
      return false;
    }

after :

if (!isPointerEvent || !isMovementEvent) {
      return false;
    }

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@github-actions github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. team-android Owned by Android platform team labels Nov 15, 2025
@AbdeMohlbi AbdeMohlbi changed the title WIP sSmall cleanup in AndroidTouchProcessor.java‎ Nov 15, 2025
@AbdeMohlbi AbdeMohlbi changed the title sSmall cleanup in AndroidTouchProcessor.java‎ Small cleanup in AndroidTouchProcessor.java‎ Nov 15, 2025
@AbdeMohlbi AbdeMohlbi marked this pull request as ready for review November 15, 2025 15:07
@AbdeMohlbi AbdeMohlbi requested a review from a team as a code owner November 15, 2025 15:07
@AbdeMohlbi AbdeMohlbi requested a review from reidbaker November 15, 2025 15:07
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logically this is the same and it does follow java best practices.

WANT_LGTM from @gmackall.

@reidbaker reidbaker requested a review from gmackall November 17, 2025 15:31
@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 17, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Nov 17, 2025
Merged via the queue into flutter:master with commit 08f1b66 Nov 17, 2025
184 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 18, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 18, 2025
flutter/flutter@cc14ef5...cb7b7df

2025-11-18 15619084+vashworth@users.noreply.github.com Enable UIScene Migration and update create templates (flutter/flutter#178700)
2025-11-18 Minsuk Jung Fix #160622: change containsWatchConpanion function to detect companion watch apps defined by only the project info file. (flutter/flutter#176832)
2025-11-18 engine-flutter-autoroll@skia.org Roll Skia from 614e71550fc3 to ca906091e199 (2 revisions) (flutter/flutter#178716)
2025-11-18 bkonyi@google.com Revert "[ Tool ] Don't delete `.dart_tool/widget_preview_scaffold` during `flutter clean` (#175664)" (flutter/flutter#178672)
2025-11-18 6655696+guidezpl@users.noreply.github.com Add missing flutter_lints dev dependencies (flutter/flutter#178105)
2025-11-18 engine-flutter-autoroll@skia.org Roll Skia from ec2f626cdcad to 614e71550fc3 (3 revisions) (flutter/flutter#178708)
2025-11-18 engine-flutter-autoroll@skia.org Roll Dart SDK from a8ad764281e3 to 312845b06afc (1 revision) (flutter/flutter#178704)
2025-11-18 engine-flutter-autoroll@skia.org Roll Skia from d7268f8245f2 to ec2f626cdcad (1 revision) (flutter/flutter#178703)
2025-11-18 116356835+AbdeMohlbi@users.noreply.github.com Refactor SnackBar behavior selection example to use `RadioGroup` (flutter/flutter#178618)
2025-11-18 zhongliu88889@gmail.com Add framework-side hitTestBehavior support for Semantics widget and apply to ModalRoute (flutter/flutter#177570)
2025-11-18 huy@nevercode.io Fix deprecation warning in some API examples using RadioListTile (flutter/flutter#178635)
2025-11-18 engine-flutter-autoroll@skia.org Roll Skia from 47fd0d9b1044 to d7268f8245f2 (6 revisions) (flutter/flutter#178695)
2025-11-18 engine-flutter-autoroll@skia.org Roll Dart SDK from cf94632d94a1 to a8ad764281e3 (1 revision) (flutter/flutter#178694)
2025-11-18 69134234+sutes-work@users.noreply.github.com [fuchsia] Add wrapper for zx_iob_writev (flutter/flutter#178626)
2025-11-17 31859944+LongCatIsLooong@users.noreply.github.com Make a11y `computeChildGeometry` slightly faster (flutter/flutter#177477)
2025-11-17 bruno.leroux@gmail.com Fix DropdownMenu width when decorationBuilder provides label (flutter/flutter#178465)
2025-11-17 bruno.leroux@gmail.com Add DropdownMenuFormField.decorationBuilder (flutter/flutter#178640)
2025-11-17 engine-flutter-autoroll@skia.org Roll Skia from 84c83c0dfb4a to 47fd0d9b1044 (4 revisions) (flutter/flutter#178673)
2025-11-17 116356835+AbdeMohlbi@users.noreply.github.com Small cleanup in `AndroidTouchProcessor.java‎` (flutter/flutter#178574)
2025-11-17 116356835+AbdeMohlbi@users.noreply.github.com Remove unnecessary `final` modifier in `StandardMessageCodec.java‎` (flutter/flutter#178598)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
IvoneDjaja pushed a commit to IvoneDjaja/flutter that referenced this pull request Nov 22, 2025
before :
```java
 if (isPointerEvent && isMovementEvent) {
      // Continue.
    } else {
      return false;
    }
```
after :
```java
if (!isPointerEvent || !isMovementEvent) {
      return false;
    }
```
## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels. platform-android Android applications specifically team-android Owned by Android platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants