Skip to content

[web] Roll Chrome to version 137 and Firefox to version 136. #170760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

harryterkelsen
Copy link
Contributor

@harryterkelsen harryterkelsen commented Jun 17, 2025

This updates the Chrome version used for testing to 137. It also updates Firefox to version 136.

This also updates how we set up Chrome Devtools Protocol to avoid focus issues when the page running the test isn't focused.

Fixes #168686

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added engine flutter/engine repository. See also e: labels. platform-web Web applications specifically labels Jun 17, 2025
@harryterkelsen harryterkelsen requested a review from mdebbar June 17, 2025 20:47
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -91,7 +89,7 @@ class Chrome extends Browser {
final String dir = await generateUserDirectory(installation, useDwarf);
final List<String> args = <String>[
'--user-data-dir=$dir',
kBlankPageUrl,
url.toString(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, so this was the issue? Nice job tracking it down!!

@matanlurey
Copy link
Contributor

Doesn't seem to work? All of the Linux web_skwasm_tests are failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine flutter/engine repository. See also e: labels. platform-web Web applications specifically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web] Engine test failures in Chrome v128.0.6543.0
3 participants