-
Notifications
You must be signed in to change notification settings - Fork 28.7k
Add announce support to the engine #169685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add announce support to the engine #169685
Conversation
…' into feat/announcements-part1(engine)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a suggestion on web platform
autosubmit label was removed for flutter/flutter/169685, because - The status or check suite Linux web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
…' into feat/announcements-part1(engine)
autosubmit label was removed for flutter/flutter/169685, because - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Partly of #165510
Partly re-lands #165531
The PR was originally reverted due to an issue with an internal Google test. I split re-land PR into two separate ones so that we can individually revert in case it fails again.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.