Skip to content

iOS: Drop iOS 13.0 @available checks #167833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Apr 26, 2025
Merged

iOS: Drop iOS 13.0 @available checks #167833

auto-submit merged 2 commits into from
Apr 26, 2025

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Apr 25, 2025 •
edited
Loading

After migrating our iOS deployment target to 13.0 in #167737, these checks are no longer necessary.

Issue: #167735

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
iOS: Drop iOS 13.0 @available checks
c97ea23 
After migrating our iOS deployment target to 13.0 in flutter#167737, these
checks are no longer necessary.

Issue: flutter#167735
@cbracken cbracken requested a review from a team as a code owner April 25, 2025 18:09
@github-actions github-actions bot added platform-ios iOS applications specifically engine flutter/engine related. See also e: labels. team-ios Owned by iOS platform team labels Apr 25, 2025
@cbracken cbracken requested a review from stuartmorgan-g April 25, 2025 18:09
cbracken
cbracken commented Apr 25, 2025
View reviewed changes
...l/platform/darwin/ios/framework/Source/UIViewController_FlutterScreenAndSceneIfLoadedTest.mm
- (void)testScreenIfViewLoadedReturnsMainScreenBeforeIOS13 {
if (@available(iOS 13.0, *)) {
return;
}
Copy link
Member Author

@cbracken cbracken Apr 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff is really unfortunate, but to clarify, this test was deleted, and the implementation of the above test (testWindowSceneIfViewLoadedReturnsNilIfViewNotLoaded) is now below.

stuartmorgan-g
stuartmorgan-g approved these changes Apr 25, 2025
View reviewed changes
@cbracken cbracken force-pushed the drop-at-available-ios-13 branch from a60c7c5 to b5cf0ba Compare April 25, 2025 18:46
@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 25, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 25, 2025
Merged via the queue into flutter:master with commit 1cc4d32 Apr 26, 2025
179 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 26, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
a5076a7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
297f9a9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
be8d7d2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
56c38cd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
3fa1565
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
26473b7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
13ebd68
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
dfa42a3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
9164521
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
2d11343
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
836e7d5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
d269c2e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
d780bea
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
6e75d1a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
52e8bc4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
23b7c9a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
69e1d84
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
dced5f7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
1c8dd31
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
342c59d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
c57ab16
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
4a2c609
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
8b6869f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
bf41dad
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
6d2e41d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
97c112a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
bb959cf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
b94d952
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
21e83d9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
162a25d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
784a543
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
5d23524
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@cbracken @romanejaquez
iOS: Drop iOS 13.0 @available checks (flutter#167833)
6c9d8e8 
After migrating our iOS deployment target to 13.0 in flutter#167737, these
checks are no longer necessary.

Issue: flutter#167735

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
8ce64e0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
5ba2947
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
1cc4d3299 iOS: Drop iOS 13.0 @available checks (flutter/flutter#167833)
1faf3c8
@cbracken cbracken deleted the drop-at-available-ios-13 branch September 24, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@hellohuanlin hellohuanlin hellohuanlin approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. platform-ios iOS applications specifically team-ios Owned by iOS platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cbracken @stuartmorgan-g @hellohuanlin