Fix regression in NDK version checking

[gmackall]

Fixes a regression from #166727, see https://discord.com/channels/608014603317936148/846507907876257822/1360306682999210204

Adds a dependency on shared_preferences_android to the smoke tests we have that run across the range of AGP/Gradle versions we support. Chosen randomly, just to recreate the error. Hopefully this doesn't push the test target into timeout range, it was already a kind of long running one.

The IDE suggestion here was misleading, as this value switched from nullable to non nullable in AGP 8.1/8.2. Unfortunately the IDE makes these suggestions based on one AGP version, specified in the project level build.gradle.kts. I checked all other files with our minimum supported AGP version, and this was the only error.

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
• I signed the CLA.
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• I followed the breaking change policy and added Data Driven Fixes where supported.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[stuartmorgan-g]

This should use a pinned version (e.g., shared_preferences_android:2.4.9), so that it's not subject to OOB breakage, or to no longer testing the thing it's supposed to be testing (e.g., if we later change it to an FFI package instead of a plugin).

[gmackall]

changed to suggested

[stuartmorgan-g]

LGTM

[jtmcdole]

I think this has very real failures:

[2025-04-11 20:58:08.873316] [STDOUT] stdout: Warning: The plugin shared_preferences_android requires Android SDK version 35 or higher.
[2025-04-11 20:58:08.873462] [STDOUT] stdout: For more information about build configuration, see https://flutter.dev/to/review-gradle-config.
[2025-04-11 20:58:09.071880] [STDOUT] stderr: 
[2025-04-11 20:58:09.173036] [STDOUT] stderr: FAILURE: Build failed with an exception.
[2025-04-11 20:58:09.173231] [STDOUT] stderr: 
[2025-04-11 20:58:09.173294] [STDOUT] stderr: * What went wrong:
[2025-04-11 20:58:09.173324] [STDOUT] stderr: A problem occurred configuring project ':shared_preferences_android'.
[2025-04-11 20:58:09.173501] [STDOUT] stderr: > Parameter specified as non-null is null: method com.flutter.gradle.VersionUtils.mostRecentSemanticVersion, parameter version1
[2025-04-11 20:58:09.173550] [STDOUT] stderr: 
[2025-04-11 20:58:09.173576] [STDOUT] stderr: * Try:
[2025-04-11 20:58:09.173608] [STDOUT] stderr: > Run with --stacktrace option to get the stack trace.
[2025-04-11 20:58:09.175501] [STDOUT] stderr: > Run with --info or --debug option to get more log output.
[2025-04-11 20:58:09.175592] [STDOUT] stderr: > Run with --scan to get full insights.
[2025-04-11 20:58:09.175622] [STDOUT] stderr: 
[2025-04-11 20:58:09.175652] [STDOUT] stderr: * Get more help at https://help.gradle.org
[2025-04-11 20:58:09.175674] [STDOUT] stderr: 
[2025-04-11 20:58:09.175694] [STDOUT] stderr: BUILD FAILED in 13s
[2025-04-11 20:58:09.547670] [STDOUT] stdout: Running Gradle task 'assembleDebug'...                             13.6s
[2025-04-11 20:58:09.563038] [STDOUT] stderr: Gradle task assembleDebug failed with exit code 1
[2025-04-11 20:58:09.576212] [STDOUT] Checking for reboot
[2025-04-11 20:58:09.577459] [STDOUT] Executing "/b/s/w/ir/cache/android/sdk/platform-tools/adb devices -l" in "/b/s/w/ir/x/w/rc/tmprkwdsotv/flutter sdk/dev/devicelab" with environment {BOT: true, LANG: en_US.UTF-8}
[2025-04-11 20:58:09.591136] [STDOUT] stdout: List of devices attached
[2025-04-11 20:58:09.591260] [STDOUT] stdout: 
[android_java17_dependency_smoke_tests] Process terminated with exit code 0.
Task result:
{
  "success": false,
  "reason": "Failed to build app with Gradle 8.0, AGP 8.0.0, and Kotlin 1.8.22, error was:\nExecutable \"/b/s/w/ir/x/w/rc/tmprkwdsotv/flutter sdk/bin/flutter\" failed with exit code 1."
}

[gmackall]

Reason for revert: #166998 (comment)

[gmackall]

I commented out the use of ndkVersionIfUnspecified to locally verify that the test was properly testing the issue, but made the mistake of pushing that change in addition to the change to the test

[gmackall]

And this test only runs in postsubmit so it wasn't caught on the presubmits

[gmackall]

Will add both

dev/devicelab/lib/framework/dependency_smoke_test_task_definition.dart
packages/flutter_tools/gradle/**

to the runif for the java 11 and 17 versions of this task in the reland to ensure this doesn't happen again