Skip to content

[web] Actual removal of HTML code #164003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 24, 2025
Merged

[web] Actual removal of HTML code #164003

merged 3 commits into from
Feb 24, 2025

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Feb 24, 2025 •
edited
Loading

All usages of this code have been cleaned up. There's nothing using this code at this point.

Closes #145954

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine repository. See also e: labels. platform-web Web applications specifically labels Feb 24, 2025
@yjbanov
Copy link
Contributor

yjbanov commented Feb 24, 2025

This needs to be reviewed by @jonahwilliams :)

jonahwilliams
jonahwilliams approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 24, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 24, 2025
Merged via the queue into flutter:master with commit 6b5b468 Feb 24, 2025
177 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 24, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
6b5b468 [web] Actual removal of HTML code (flutter/flutter#164003)
47bc913
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
6b5b468 [web] Actual removal of HTML code (flutter/flutter#164003)
c48966d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
6b5b468 [web] Actual removal of HTML code (flutter/flutter#164003)
b70da18
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
6b5b468 [web] Actual removal of HTML code (flutter/flutter#164003)
ae2e413
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
6b5b468 [web] Actual removal of HTML code (flutter/flutter#164003)
9e3f1ef
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
6b5b468 [web] Actual removal of HTML code (flutter/flutter#164003)
3fc406f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
6b5b468 [web] Actual removal of HTML code (flutter/flutter#164003)
1df4632
@mdebbar mdebbar deleted the engine_html_2 branch February 25, 2025 20:54
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
6b5b468 [web] Actual removal of HTML code (flutter/flutter#164003)
92adc26
@yjbanov yjbanov mentioned this pull request May 27, 2025
Closed
@mdebbar mdebbar mentioned this pull request May 27, 2025
Closed
@yjbanov yjbanov mentioned this pull request May 27, 2025
Closed
@mdebbar mdebbar mentioned this pull request May 27, 2025
Closed
2 tasks
This was referenced May 27, 2025
Closed
Closed
@mdebbar mdebbar mentioned this pull request May 27, 2025
Closed
2 tasks
@yjbanov yjbanov mentioned this pull request May 27, 2025
Closed
@mdebbar mdebbar mentioned this pull request May 27, 2025
Closed
This was referenced May 27, 2025
Closed
Closed
@mdebbar mdebbar mentioned this pull request May 27, 2025
Closed
2 tasks
@yjbanov yjbanov mentioned this pull request May 27, 2025
Closed
@mdebbar mdebbar mentioned this pull request May 27, 2025
Closed
@yjbanov yjbanov mentioned this pull request May 27, 2025
Closed
@mdebbar mdebbar mentioned this pull request May 27, 2025
Closed
2 tasks
@yjbanov yjbanov mentioned this pull request May 27, 2025
Closed
@mdebbar mdebbar mentioned this pull request May 27, 2025
Closed
2 tasks
@yjbanov yjbanov mentioned this pull request May 27, 2025
Closed
@mdebbar mdebbar mentioned this pull request May 27, 2025
Closed
2 tasks
This was referenced May 27, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems engine flutter/engine repository. See also e: labels. platform-web Web applications specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

☂️ Intent to deprecate and remove the HTML renderer in Flutter Web
3 participants
@mdebbar @yjbanov @jonahwilliams