Skip to content

Convert SkiaException to TestFailure on post-submit. #162623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2025
Merged

Convert SkiaException to TestFailure on post-submit. #162623

merged 1 commit into from
Feb 3, 2025

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Feb 3, 2025

Fixes #162621.

I believe this has no other implications, other than it's possible to catch TestFailure where it should be catchable today.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Feb 3, 2025
Piinks
Piinks approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 3, 2025
Merged via the queue into flutter:master with commit bcb305c Feb 3, 2025
75 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2025
This was referenced Feb 3, 2025
Closed
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
91f4846 
…tter/flutter#162623)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
3003abc 
…tter/flutter#162623)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
b702913 
…tter/flutter#162623)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
e290824 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
60d4706 
…tter/flutter#162623)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
084dfb4 
…tter/flutter#162623)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
18a989b 
…tter/flutter#162623)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
bbd4652 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
d2c4706 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
0e694a7 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
26d9d72 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
162b4d9 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
55bf070 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
833bcb3 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
4245f24 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
d1483ae 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
4a28fdf 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
6b8fab9 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
e4679ee 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
a2e03ac 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
86447c8 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
37164f2 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
95d4775 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
47007a1 
…tter/flutter#162623)
@matanlurey matanlurey mentioned this pull request Feb 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
ada4c5d 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
119a921 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
62fd943 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
661559b 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
92540b5 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
1b4536c 
…tter/flutter#162623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
bcb305c Convert SkiaException to TestFailure on post-submit. (flu…
e460ee8 
…tter/flutter#162623)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Report failed Skia golden comparisons on post-submit should as test failures

3 participants

@matanlurey @reidbaker @Piinks