Fix issue #156954: Wrong dateHelpText in MaterialLocalizationIt #161889
Conversation
github-actions
bot
added
framework
|
By the way, for some reason, after signing the agreement in the welcome channel on your Discord server, I get kicked out after a few minutes. However, I can rejoin using the invite link, but the same thing happens again and again. I couldn’t find information in the documentation on who to contact about this, but since you’re the observer of Issue#156954 and also a team member, Kate, I decided to tag you. Perhaps you could also take a look at my first pull request? :) cc @Piinks |
| @@ -21192,7 +21192,7 @@ class MaterialLocalizationIt extends GlobalMaterialLocalizations { | |||
| String get cutButtonLabel => 'Taglia'; | |||
|
|
|||
| @override | |||
| String get dateHelpText => 'mm/gg/aaaa'; | |||
| String get dateHelpText => 'gg/mm/aaaa'; | |||
There was a problem hiding this comment.
At the top of this file:
// This file has been automatically generated. Please do not edit it manually.
There was a problem hiding this comment.
Was this change added manually, or by regenerating this file?
There was a problem hiding this comment.
Yes, I generated it by dart dev/tools/localization/bin/gen_localizations.dart --overwrite as it describes in this chapter
Paulik8
force-pushed
the
fix/issue-156954
branch
from
56bf5fc to
d41505d
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
…t - flutter_localizations
Piinks
force-pushed
the
fix/issue-156954
branch
from
d41505d to
781906d
Compare
|
Rebased to resolve an unrelated flaky golden file test. This should be able to land now. |
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/161889, because - The status or check suite Windows framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter-dashboard
bot
removed
the
autosubmit
Fix #156954
dataHelpTextused inMaterialLocalizationItfrom "mm/gg/aaaa" to "gg/mm/aaaa"Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.