Support ignoring pointer events on tooltip overlay (#142465) #161363

BenjiFarquhar · 2025-01-09T06:41:04Z

As #142465 states, tooltips often interrupt widget interactivity by not allowing events to pass through to the Tooltip child, which is especially poor UX when hovering interact-able widgets on web when the mouse happens to land on the tooltip.

I've gone with defaulting ignorePointer to true when a simple message is supplied, since there won't ever be anything interact-able on the Tooltip, and defaulting to false when richMessage is supplied, so it doesn't break anyone's code that has interact-able widgets in the Tooltip.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

BenjiFarquhar · 2025-01-10T20:01:02Z

The function 'ensureAndroidOrIosDevice' isn't defined

Anyone know what these build pipeline errors are? I think not related to my PR?

nate-thegrate · 2025-01-15T22:38:17Z

The function 'ensureAndroidOrIosDevice' isn't defined

Anyone know what these build pipeline errors are? I think not related to my PR?

I saw this same error in another recent PR, so I believe you're right that it's unrelated to this change. At this point we can probably fix it with a rebase.

nate-thegrate

As far as the implementation, this LGTM 👍
It's great to see #142465 being solved in a simple & effective way.

As far as backward-compatibility: let's get all the other checks passing and then see what Google Testing does!

packages/flutter/lib/src/material/tooltip.dart

BenjiFarquhar · 2025-01-21T06:43:19Z

@nate-thegrate Thanks for the review! Looks like everything has passed 🙂

nate-thegrate

LGTM, thank you!

This approval should kick off Google Testing; I guess we'll see how it goes 😃

BenjiFarquhar · 2025-01-22T17:06:48Z

@nate-thegrate Cheers! Looks like it's ready to merge

BenjiFarquhar · 2025-02-02T23:56:58Z

@dkwingsmt Hi. Looking like you will get this review done this week?

dkwingsmt

LGTM, thanks for the change! I'm ok with this default behavior change.

(And sorry for the delayed review!)

justinmc

LGTM with a nit 👍

packages/flutter/lib/src/material/tooltip.dart

…lutter/flutter#161363)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jan 9, 2025

BenjiFarquhar changed the title ~~Support ignoring pointer events on overlay (#142465)~~ Support ignoring pointer events on tooltip overlay (#142465) Jan 9, 2025

Piinks requested a review from nate-thegrate January 15, 2025 19:23

nate-thegrate reviewed Jan 15, 2025

View reviewed changes

packages/flutter/lib/src/material/tooltip.dart Outdated Show resolved Hide resolved

nate-thegrate approved these changes Jan 21, 2025

View reviewed changes

dkwingsmt self-requested a review January 22, 2025 19:34

dkwingsmt approved these changes Feb 3, 2025

View reviewed changes

justinmc approved these changes Feb 4, 2025

View reviewed changes

packages/flutter/lib/src/material/tooltip.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/material/tooltip.dart Show resolved Hide resolved

Support ignoring pointer events on tooltip overlay (#142465)

53e3c29

justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 4, 2025

auto-submit bot added this pull request to the merge queue Feb 4, 2025

Merged via the queue into flutter:master with commit aa27e78 Feb 4, 2025
77 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 4, 2025

BenjiFarquhar deleted the tooltip-ignore-pointer branch February 4, 2025 19:37

engine-flutter-autoroll mentioned this pull request Feb 5, 2025

Roll Flutter from 8e2a6fc3fd2c to dfb36f032e6d (46 revisions) flutter/packages#8568

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

e706cee

…lutter/flutter#161363)

engine-flutter-autoroll mentioned this pull request Feb 5, 2025

Roll Flutter from 8e2a6fc3fd2c to dfb36f032e6d (46 revisions) flutter/packages#8569

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

46e649b

…lutter/flutter#161363)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

a440218

…lutter/flutter#161363)

This was referenced Feb 5, 2025

Roll Flutter from 8e2a6fc3fd2c to 3b3936a703db (47 revisions) flutter/packages#8571

Closed

Roll Flutter from 8e2a6fc3fd2c to f219bbac5514 (67 revisions) flutter/packages#8576

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

f48ad47

…lutter/flutter#161363)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

bdad037

…lutter/flutter#161363)

engine-flutter-autoroll mentioned this pull request Feb 6, 2025

Roll Flutter from 8e2a6fc3fd2c to f219bbac5514 (67 revisions) flutter/packages#8577

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

2891728

…lutter/flutter#161363)

engine-flutter-autoroll mentioned this pull request Feb 6, 2025

Roll Flutter from 8e2a6fc3fd2c to 0e59f0f64c6a (68 revisions) flutter/packages#8579

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

6c8866b

…lutter/flutter#161363)

engine-flutter-autoroll mentioned this pull request Feb 6, 2025

Roll Flutter from 8e2a6fc3fd2c to 5944d992ac40 (69 revisions) flutter/packages#8581

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

ebff682

…lutter/flutter#161363)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

f23b6a1

…lutter/flutter#161363)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

c38c19d

…lutter/flutter#161363)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

b2f9938

…lutter/flutter#161363)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

4d2240c

…lutter/flutter#161363)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

4d3a9d1

…lutter/flutter#161363)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

dc83b6e

…lutter/flutter#161363)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

a848212

…lutter/flutter#161363)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

9796121

…lutter/flutter#161363)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

c2a456b

…lutter/flutter#161363)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

231a9a8

…lutter/flutter#161363)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

563d01e

…lutter/flutter#161363)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

2739c05

…lutter/flutter#161363)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

9f85776

…lutter/flutter#161363)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

7f80788

…lutter/flutter#161363)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

17828d0

…lutter/flutter#161363)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

8293ee4

…lutter/flutter#161363)

This was referenced Mar 4, 2025

Setting an offset for the Tooltip can cause the GestureDetector's tap event to become ineffective. #158422

Closed

Tooltips get in the way of hovering other widgets on web and desktop platforms. #142465

Closed

Piinks mentioned this pull request May 8, 2025

Page scrolling is impossible when the cursor hits a Tooltip in the web #167042

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

e8a448b

…lutter/flutter#161363)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

1318fb2

…lutter/flutter#161363)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

aa27e78 Support ignoring pointer events on tooltip overlay (#142465) (f…

b01d6eb

…lutter/flutter#161363)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support ignoring pointer events on tooltip overlay (#142465) #161363

Support ignoring pointer events on tooltip overlay (#142465) #161363

Uh oh!

BenjiFarquhar commented Jan 9, 2025 •

edited

Loading

Uh oh!

BenjiFarquhar commented Jan 10, 2025

Uh oh!

nate-thegrate commented Jan 15, 2025

Uh oh!

nate-thegrate left a comment

Uh oh!

Uh oh!

BenjiFarquhar commented Jan 21, 2025

Uh oh!

nate-thegrate left a comment

Uh oh!

BenjiFarquhar commented Jan 22, 2025

Uh oh!

BenjiFarquhar commented Feb 2, 2025

Uh oh!

dkwingsmt left a comment

Uh oh!

justinmc left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Support ignoring pointer events on tooltip overlay (#142465) #161363

Support ignoring pointer events on tooltip overlay (#142465) #161363

Uh oh!

Conversation

BenjiFarquhar commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

BenjiFarquhar commented Jan 10, 2025

Uh oh!

nate-thegrate commented Jan 15, 2025

Uh oh!

nate-thegrate left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BenjiFarquhar commented Jan 21, 2025

Uh oh!

nate-thegrate left a comment

Choose a reason for hiding this comment

Uh oh!

BenjiFarquhar commented Jan 22, 2025

Uh oh!

BenjiFarquhar commented Feb 2, 2025

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BenjiFarquhar commented Jan 9, 2025 •

edited

Loading