Skip to content

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Dec 19, 2024

Not sure if dart fix will support dart:X but let's see... following up in dart-lang/sdk#59764

Would fix #160617

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. c: tech-debt Technical debt, code quality, testing, etc. labels Dec 19, 2024
@matanlurey
Copy link
Contributor

This isn't a "real" package, so I doubt this will work as expected :-/

(Could we put the fixes in packages/flutter instead of in the engine, possibly?)

@Piinks
Copy link
Contributor Author

Piinks commented Dec 19, 2024

(Could we put the fixes in packages/flutter instead of in the engine, possibly?)

Would definitely prefer that!

@bwilkerson just shared in dart-lang/sdk#59764:

So the right answer here is probably to have a second place to look for fixes related to dart: libraries.

If so, we should be able to choose where that is!

@matanlurey
Copy link
Contributor

Cool - I'm happy to review (I didn't make most of the Color changes but I'm pretty familiar with them)

@Piinks
Copy link
Contributor Author

Piinks commented Jan 7, 2025

Closing as it is currently blocked on dart-lang/sdk#59764

@Piinks Piinks closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: tech-debt Technical debt, code quality, testing, etc. engine flutter/engine related. See also e: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color deprecations should have a dart fix
2 participants