Skip to content

Roll Flutter Engine from 7c5c5fe5c84d to 33f906426d06 (1 revision) #157652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

engine-flutter-autoroll
Copy link
Contributor

flutter/engine@7c5c5fe...33f9064

2024-10-25 jacksongardner@google.com Reland (x2) Skwasm overlay optimizations (flutter/engine#56067)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@engine-flutter-autoroll engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 25, 2024
@github-actions github-actions bot added the engine flutter/engine repository. See also e: labels. label Oct 25, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 25, 2024
Copy link
Contributor

auto-submit bot commented Oct 25, 2024

auto label is removed for flutter/flutter/157652, due to - The status or check suite Windows build_tests_6_8 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #157652 at sha 1b414c0

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Oct 26, 2024
@engine-flutter-autoroll engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 26, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 26, 2024
Copy link
Contributor

auto-submit bot commented Oct 26, 2024

auto label is removed for flutter/flutter/157652, due to - The status or check suite Windows build_tests_6_8 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@engine-flutter-autoroll
Copy link
Contributor Author

Commit queue failed; closing this roll.

@engine-flutter-autoroll engine-flutter-autoroll deleted the flutter-engine-flutter-autoroll-d9c2264b-192e-4dfb-9803-38bf9cbad63e-1729898033 branch November 1, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine flutter/engine repository. See also e: labels. will affect goldens Changes to golden files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants