Skip to content

Add drawer and navigation drawer in a11y assessment app, also run dart format under a11y_assessments/ #153034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

hannah-hyj
Copy link
Member

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@hannah-hyj hannah-hyj requested a review from chunhtai August 7, 2024 17:11
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Aug 7, 2024
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2024
@auto-submit auto-submit bot merged commit 9b281be into flutter:master Aug 8, 2024
135 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 8, 2024
Manual roll requested by tarrinneal@google.com

flutter/flutter@d595e98...b6cd31e

2024-08-08 parlough@gmail.com Add a contribution doc on using reliable links in tooling (flutter/flutter#150962)
2024-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 94cf8c8fad31 to 3978ddd8d7a7 (1 revision) (flutter/flutter#153086)
2024-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9dd4a2303898 to 94cf8c8fad31 (2 revisions) (flutter/flutter#153073)
2024-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9932f34aac4e to 9dd4a2303898 (1 revision) (flutter/flutter#153067)
2024-08-08 jhy03261997@gmail.com Add drawer and navigation drawer in a11y assessment app, also run `dart format` under a11y_assessments/ (flutter/flutter#153034)
2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from d4d9537bccdf to 9932f34aac4e (1 revision) (flutter/flutter#153063)
2024-08-07 leroux_bruno@yahoo.fr Clean up MenuAnchor (flutter/flutter#152946)
2024-08-07 kerber.jg@gmail.com Set default Cupertino `primaryContrastingColor` to white (flutter/flutter#153039)
2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 317eb6107646 to d4d9537bccdf (2 revisions) (flutter/flutter#153058)
2024-08-07 tylerholland@google.com Allow dropdown_menu to accept any EdgeInsetsGeometry (flutter/flutter#153053)
2024-08-07 magder@google.com Add xcresulttool --legacy flag for deprecated usage (flutter/flutter#152988)
2024-08-07 magder@google.com Revert "Marks Mac channels_integration_test to be flaky" (flutter/flutter#153044)
2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 69c29fb309bb to 317eb6107646 (2 revisions) (flutter/flutter#153048)
2024-08-07 fluttergithubbot@gmail.com Marks Linux android_java17_dependency_smoke_tests to be unflaky (flutter/flutter#153011)
2024-08-07 fluttergithubbot@gmail.com Marks Linux android_java11_dependency_smoke_tests to be unflaky (flutter/flutter#153010)
2024-08-07 yjbanov@google.com [web] hide the --web-renderer option in the tool (flutter/flutter#152683)
2024-08-07 goderbauer@google.com Doc imports again (flutter/flutter#152958)
2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5a0fd5fbecc6 to 69c29fb309bb (6 revisions) (flutter/flutter#153035)
2024-08-07 engine-flutter-autoroll@skia.org Roll Packages from 551bde5 to 5cc0a01 (12 revisions) (flutter/flutter#153040)
2024-08-07 59215665+davidhicks980@users.noreply.github.com MenuAnchor hover traversal fixes (flutter/flutter#150914)
2024-08-07 34465683+rkishan516@users.noreply.github.com Style: Rename CupertinoSwitch activeColor and trackColor to activeTrackColor and InactiveTrackColor (flutter/flutter#151367)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33 pushed a commit to DBowen33/flutter that referenced this pull request Aug 16, 2024
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants