Reverts "Reland Add UI Benchmarks (#143542) (#143799)" #143946

auto-submit · 2024-02-22T17:14:45Z

Initiated by: goderbauer

Reason for reverting: The microbenchmark failed two run two times in a row after this was committed (see https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8755379171959141089/+/u/run_microbenchmarks/stdout).

Original PR Author: bernaferrari

Reviewed By: {goderbauer}

This change reverts the following previous change:
Original Description:
Re-lands #143542 (which is part 1 of #138481)

The filename was wrong 🫠

This reverts commit 063f59f.

goderbauer · 2024-02-22T17:15:45Z

cc @bernaferrari Sorry about this. I scanned the log (https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8755379171959141089/+/u/run_microbenchmarks/stdout), but it wasn't immediately clear to me why this fails.

bernaferrari · 2024-02-22T17:18:39Z

Oh no :( Yeah, I have no clue too.. There is no exception.

…er/flutter#143946)

flutter/flutter@41581c9...39585e6 2024-02-23 jonahwilliams@google.com Re-enable Impeller goldens blocking. (flutter/flutter#144023) 2024-02-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0f3ad23b84ed to 5f99a6c3289e (16 revisions) (flutter/flutter#144028) 2024-02-23 engine-flutter-autoroll@skia.org Roll Packages from 078c2a3 to 7df2085 (3 revisions) (flutter/flutter#144030) 2024-02-23 15619084+vashworth@users.noreply.github.com Run tests on iOS 17 exclusively (flutter/flutter#144022) 2024-02-23 15619084+vashworth@users.noreply.github.com Retry button tap in [FlutterUITests testFlutterViewWarm] (flutter/flutter#143967) 2024-02-23 31859944+LongCatIsLooong@users.noreply.github.com Remove deprecated `InteractiveViewer.alignPanAxis` (flutter/flutter#142500) 2024-02-23 31859944+LongCatIsLooong@users.noreply.github.com Remove deprecated `KeepAliveHandle.release` (flutter/flutter#143961) 2024-02-23 goderbauer@google.com Remove deprecated AnimatedListItemBuilder, AnimatedListRemovedItemBuilder (flutter/flutter#143974) 2024-02-23 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 06448ee8165f to 0f3ad23b84ed (16 revisions) (flutter/flutter#143989) 2024-02-23 katelovett@google.com Remove deprecated TimelineSummary.writeSummaryToFile (flutter/flutter#143983) 2024-02-23 54558023+keyonghan@users.noreply.github.com Remove unused drone_dimension field (flutter/flutter#143984) 2024-02-23 goderbauer@google.com Remove deprecated MediaQuery.boldTextOverride (flutter/flutter#143960) 2024-02-22 goderbauer@google.com Revert engine back to 06448ee8165f4ff6579ef9510ac69322eda896ac (flutter/flutter#143986) 2024-02-22 katelovett@google.com Remove deprecated FlutterDriver.enableAccessibility (flutter/flutter#143979) 2024-02-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from cb6115d3a6ab to c5d2e011652b (3 revisions) (flutter/flutter#143980) 2024-02-22 36861262+QuncCccccc@users.noreply.github.com Revert "Introduce tone-based surfaces and accent color add-ons - Part 2" (flutter/flutter#143973) 2024-02-22 110420204+dsanagustin@users.noreply.github.com Add CloseButtonTooltip to the 'X' button on a SnackBar (flutter/flutter#143934) 2024-02-22 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.3 to 3.24.4 (flutter/flutter#143971) 2024-02-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 06448ee8165f to cb6115d3a6ab (10 revisions) (flutter/flutter#143972) 2024-02-22 kustermann@google.com Use inlining annotations on important methods for all targets (flutter/flutter#143923) 2024-02-22 31859944+LongCatIsLooong@users.noreply.github.com Add missing `TextPainter.strutStyle` to paragraph style (flutter/flutter#143771) 2024-02-22 zanderso@users.noreply.github.com Shift Moto G4 staging tests to A02s (flutter/flutter#143957) 2024-02-22 sokolovskyi.konstantin@gmail.com Add CurvedAnimation disposals in some widgets (flutter/flutter#143790) 2024-02-22 andrew@divineflame.com Fix documentation typo in basic.dart (flutter/flutter#143887) 2024-02-22 pateltirth454@gmail.com Fixed Small Typo in Emulators Test Name (flutter/flutter#143578) 2024-02-22 derekx@google.com Support using lightweight Flutter Engines to run tests (flutter/flutter#141726) 2024-02-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9250bfdb38c5 to 06448ee8165f (1 revision) (flutter/flutter#143943) 2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland Add UI Benchmarks (#143542) (#143799)" (flutter/flutter#143946) 2024-02-22 engine-flutter-autoroll@skia.org Roll Packages from 48048f6 to 078c2a3 (11 revisions) (flutter/flutter#143935) 2024-02-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7777480eb94d to 9250bfdb38c5 (8 revisions) (flutter/flutter#143933) 2024-02-22 bernaferrari2@gmail.com Reland Add UI Benchmarks (#143542) (flutter/flutter#143799) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…er/flutter#143946)

Revert "Reland Add UI Benchmarks (#143542) (#143799)"

487c07e

This reverts commit 063f59f.

auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Feb 22, 2024

auto-submit bot assigned goderbauer Feb 22, 2024

fluttergithubbot approved these changes Feb 22, 2024

View reviewed changes

auto-submit bot merged commit f655f59 into master Feb 22, 2024

auto-submit bot deleted the revert_063f59fbdf364f6d7d4865ccd1e843073e7291b5 branch February 22, 2024 17:15

engine-flutter-autoroll mentioned this pull request Feb 23, 2024

Roll Flutter from 41581c9a1b90 to fcd154bd247f (26 revisions) flutter/packages#6188

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024

f655f59 Reverts "Reland Add UI Benchmarks (#143542) (#143799)" (flutt…

abd995c

…er/flutter#143946)

engine-flutter-autoroll mentioned this pull request Feb 23, 2024

Roll Flutter from 41581c9a1b90 to 00229827ab7c (27 revisions) flutter/packages#6189

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024

f655f59 Reverts "Reland Add UI Benchmarks (#143542) (#143799)" (flutt…

1cd8991

…er/flutter#143946)

engine-flutter-autoroll mentioned this pull request Feb 23, 2024

Roll Flutter from 41581c9a1b90 to bb856079c401 (28 revisions) flutter/packages#6190

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024

f655f59 Reverts "Reland Add UI Benchmarks (#143542) (#143799)" (flutt…

22f0250

…er/flutter#143946)

engine-flutter-autoroll mentioned this pull request Feb 23, 2024

Roll Flutter from 41581c9a1b90 to bab5f85df560 (29 revisions) flutter/packages#6193

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024

f655f59 Reverts "Reland Add UI Benchmarks (#143542) (#143799)" (flutt…

1a4fca6

…er/flutter#143946)

engine-flutter-autoroll mentioned this pull request Feb 23, 2024

Roll Flutter from 41581c9a1b90 to 39585e66c11f (31 revisions) flutter/packages#6194

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024

f655f59 Reverts "Reland Add UI Benchmarks (#143542) (#143799)" (flutt…

8e5049b

…er/flutter#143946)

This was referenced Apr 2, 2024

Improve UI-thread animation performance on busy screens (~10x reduction depending on your use-case) #138481

Closed

Improve UI-thread animation performance through ObserverList #146211

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

f655f59 Reverts "Reland Add UI Benchmarks (#143542) (#143799)" (flutt…

30e7b4d

…er/flutter#143946)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reverts "Reland Add UI Benchmarks (#143542) (#143799)" #143946

Reverts "Reland Add UI Benchmarks (#143542) (#143799)" #143946

Uh oh!

auto-submit bot commented Feb 22, 2024

Uh oh!

goderbauer commented Feb 22, 2024

Uh oh!

bernaferrari commented Feb 22, 2024

Uh oh!

Uh oh!

Reverts "Reland Add UI Benchmarks (#143542) (#143799)" #143946

Reverts "Reland Add UI Benchmarks (#143542) (#143799)" #143946

Uh oh!

Conversation

auto-submit bot commented Feb 22, 2024

Uh oh!

goderbauer commented Feb 22, 2024

Uh oh!

bernaferrari commented Feb 22, 2024

Uh oh!

Uh oh!