Skip to content

[CP-beta]Test codesigning xcframeworks in artifacts #143015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

flutteractionsbot
Copy link

@flutteractionsbot flutteractionsbot commented Feb 6, 2024

This pull request is opened against a release branch.

To request a cherry pick of a commit, please fill in the form below.
(Questions with an asterisk are required.)

To fill in the form, you can edit this PR description and type your answers after the 'My Answer' keywords.

A flutter domain expert will evaluate this cherry pick request shortly after ALL questions are answered.

  • Issue Link: What is the link to the issue this cherry-pick is addressing?
  My Answer:
https://github.com/flutter/flutter/issues/140934

  My Answer:
This cherry pick enables code signing test to run on release branches.

  • Impacted Users: Approximately who will hit this issue (ex. all Flutter devs, Windows developers, all end-customers, apps using X framework feature)?
  My Answer:
Release engineers who run code signing tests on releases.

  • impact_description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
  My Answer:
Enabling codesigning Test would test the release artifact, and make sure both binaries and bundles are code signed.

  • Workaround: Is there a workaround for this issue?
  My Answer:
We can verify manually, but enabling an automated Code signing test would be better.

  • Risk: What is the risk level of this cherry-pick?
  My Answer:
  - [ ] Low
  - [x] Medium
  - [ ] High

  • Test Coverage: Are you confident that your fix is well-tested by automated tests?
  My Answer:
  - [x] Yes
  - [ ] No

  • Validation Steps: What are the steps to validate that this fix works?
  My Answer:
code sign test should run on post submit of release branches and pass

On the beta branch:
```
Verifying the code signature of /Users/m/Projects/flutter/bin/cache/artifacts/engine/ios-profile/extension_safe/Flutter.xcframework
Verifying the code signature of /Users/m/Projects/flutter/bin/cache/artifacts/engine/ios-profile/Flutter.xcframework
Verifying the code signature of /Users/m/Projects/flutter/bin/cache/artifacts/engine/ios/extension_safe/Flutter.xcframework
Verifying the code signature of /Users/m/Projects/flutter/bin/cache/artifacts/engine/ios/Flutter.xcframework
Verifying the code signature of /Users/m/Projects/flutter/bin/cache/artifacts/engine/ios-release/extension_safe/Flutter.xcframework
Verifying the code signature of /Users/m/Projects/flutter/bin/cache/artifacts/engine/ios-release/Flutter.xcframework
```

Fixes flutter#140934
@flutteractionsbot flutteractionsbot added the cp: review Cherry-picks in the review queue label Feb 6, 2024
@flutteractionsbot
Copy link
Author

@XilaiZhang please fill out the PR description above, afterwards the release team will review this request.

@XilaiZhang
Copy link
Contributor

@jmagman might be the best local TL to review this. cc release engineer this week @CaseyHillers

@XilaiZhang XilaiZhang added the cp: merge-to-beta Cherry-picks that should be merged to beta label Feb 6, 2024
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On this PR:

$ SHARD=verify_binaries_codesigned dart dev/bots/test.dart --verbose
▌14:20:06▐ STARTING ANALYSIS
▌14:20:06▐ SHARD=verify_binaries_codesigned
▌14:20:06▐ Running binaries codesign verification
...
Found: /Users/m/Projects/flutter/bin/cache/artifacts/engine/ios-profile/extension_safe/Flutter.xcframework

Found: /Users/m/Projects/flutter/bin/cache/artifacts/engine/ios-profile/Flutter.xcframework

Found: /Users/m/Projects/flutter/bin/cache/artifacts/engine/ios/extension_safe/Flutter.xcframework

Found: /Users/m/Projects/flutter/bin/cache/artifacts/engine/ios/Flutter.xcframework

Found: /Users/m/Projects/flutter/bin/cache/artifacts/engine/ios-release/extension_safe/Flutter.xcframework

Found: /Users/m/Projects/flutter/bin/cache/artifacts/engine/ios-release/Flutter.xcframework
...
Verifying the code signature of /Users/m/Projects/flutter/bin/cache/artifacts/engine/ios-profile/extension_safe/Flutter.xcframework
Verifying the code signature of /Users/m/Projects/flutter/bin/cache/artifacts/engine/ios-profile/Flutter.xcframework
Verifying the code signature of /Users/m/Projects/flutter/bin/cache/artifacts/engine/ios/extension_safe/Flutter.xcframework
Verifying the code signature of /Users/m/Projects/flutter/bin/cache/artifacts/engine/ios/Flutter.xcframework
Verifying the code signature of /Users/m/Projects/flutter/bin/cache/artifacts/engine/ios-release/extension_safe/Flutter.xcframework
Verifying the code signature of /Users/m/Projects/flutter/bin/cache/artifacts/engine/ios-release/Flutter.xcframework
Verified that files are codesigned and have expected entitlements.
▌14:20:55▐ Test successful.

@XilaiZhang XilaiZhang added cp: approved Approved cherry-pick request autosubmit Merge PR when tree becomes green via auto submit App labels Feb 6, 2024
@auto-submit auto-submit bot merged commit 005b8e1 into flutter:flutter-3.19-candidate.1 Feb 6, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App cp: approved Approved cherry-pick request cp: merge-to-beta Cherry-picks that should be merged to beta cp: review Cherry-picks in the review queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants