Update chip_test.dart tests for Material 3
#140964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
TahaTesser
force-pushed
the
update_chip_test_m3
branch
2 times, most recently
from
cdd3a55 to
89da5b1
Compare
QuncCccccc
reviewed
Jan 4, 2024
TahaTesser
force-pushed
the
update_chip_test_m3
branch
from
89da5b1 to
932124a
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. Changes reported for pull request #140964 at sha 932124a98ec437384103d05f0660bffb70f710fe |
QuncCccccc
approved these changes
Jan 5, 2024
TahaTesser
force-pushed
the
update_chip_test_m3
branch
from
932124a to
b959edc
Compare
8 tasks
TahaTesser
force-pushed
the
update_chip_test_m3
branch
from
b959edc to
43a088a
Compare
TahaTesser
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 9, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 9, 2024
Roll Flutter from c6ddb73 to 126302d (32 revisions) flutter/flutter@c6ddb73...126302d 2024-01-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 820645dbcc69 to b3c8597df0e2 (5 revisions) (flutter/flutter#141175) 2024-01-09 engine-flutter-autoroll@skia.org Roll Packages from 5aef49b to 09205ca (2 revisions) (flutter/flutter#141173) 2024-01-09 leroux_bruno@yahoo.fr [Android] Add custom system-wide text selection toolbar buttons for SelectableRegion (flutter/flutter#141103) 2024-01-09 tessertaha@gmail.com Update Chips and `ChipTheme` tests and for Material 3 (flutter/flutter#141022) 2024-01-09 tessertaha@gmail.com Update `chip_test.dart` tests for Material 3 (flutter/flutter#140964) 2024-01-09 leroux_bruno@yahoo.fr Fix spell check throws when text contains regex reserved characters (flutter/flutter#140384) 2024-01-09 dacoharkes@google.com Native assets support for Android Add2app (flutter/flutter#140802) 2024-01-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from d13479968b8f to 820645dbcc69 (3 revisions) (flutter/flutter#141152) 2024-01-09 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.22.11 to 3.23.0 (flutter/flutter#141132) 2024-01-09 zanderso@users.noreply.github.com Shift mac Pixel 7 Pro tests to prod (flutter/flutter#141142) 2024-01-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3f0f8913169e to d13479968b8f (2 revisions) (flutter/flutter#141147) 2024-01-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 09a74a08c819 to 3f0f8913169e (2 revisions) (flutter/flutter#141146) 2024-01-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from ee1ded6d1c44 to 09a74a08c819 (3 revisions) (flutter/flutter#141144) 2024-01-08 coffee5084@gmail.com [docs] Add document content related to chip shape (flutter/flutter#140015) 2024-01-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 00ff33274fc0 to ee1ded6d1c44 (2 revisions) (flutter/flutter#141133) 2024-01-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 70c45157c60a to 00ff33274fc0 (2 revisions) (flutter/flutter#141128) 2024-01-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from b57c899aefd7 to 70c45157c60a (1 revision) (flutter/flutter#141125) 2024-01-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from db564ffb3549 to b57c899aefd7 (1 revision) (flutter/flutter#141114) 2024-01-08 engine-flutter-autoroll@skia.org Roll Packages from b9b6d38 to 5aef49b (2 revisions) (flutter/flutter#141117) 2024-01-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from bbebee146508 to db564ffb3549 (5 revisions) (flutter/flutter#141112) 2024-01-08 zanderso@users.noreply.github.com Disable test shuffling in widget_tester_leaks_test.dart (flutter/flutter#141110) 2024-01-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 702ae19c0026 to bbebee146508 (1 revision) (flutter/flutter#141088) 2024-01-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5e1d18bb51d1 to 702ae19c0026 (1 revision) (flutter/flutter#141084) 2024-01-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 845ffd16d228 to 5e1d18bb51d1 (1 revision) (flutter/flutter#141076) 2024-01-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from ffc84af47827 to 845ffd16d228 (1 revision) (flutter/flutter#141075) 2024-01-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from cc9362752996 to ffc84af47827 (2 revisions) (flutter/flutter#141074) 2024-01-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from a5173fe3a912 to cc9362752996 (1 revision) (flutter/flutter#141066) 2024-01-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1dfcb6967dd1 to a5173fe3a912 (1 revision) (flutter/flutter#141063) 2024-01-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2fd75c06e0bd to 1dfcb6967dd1 (1 revision) (flutter/flutter#141062) 2024-01-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f872b265733 to 2fd75c06e0bd (1 revision) (flutter/flutter#141059) 2024-01-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8d1789a43319 to 7f872b265733 (1 revision) (flutter/flutter#141056) 2024-01-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from fcb40168f159 to 8d1789a43319 (1 revision) (flutter/flutter#141053) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated unit tests for
Tooltipto have M2 and M3 versions.More info in #139076
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.