resolved the issue of indeterminate CircularProgressIndicator.adaptive on Darwin

[nikkivirtuoso]

Fixes #140574

Passes the value from CircularProgressIndicator to the Cupertino version so that functionality is not lost on Apple devices.

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
• I signed the CLA.
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[nikkivirtuoso]

please review my code

[MitchellGoodwin]

Code looks good to me, with a small nit. This will need a test however. Probably one that gives a CircularProgressIndicator.adaptive a value, then checks to see if a CupertinoActivityIndicator is rendered with the expected value.

[MitchellGoodwin]

Formatting nit: move each property to a new line since this line is already long:

return CupertinoActivityIndicator.partiallyRevealed(
     key: widget.key,
     color: tickColor,
     progress: val
);

[nikkivirtuoso]

@MitchellGoodwin, sir please check now i have made the necessary changes and all test cases have passed

[MitchellGoodwin]

Nit: this has an extra indent that should be removed.

[MitchellGoodwin]

Per our policy on test coverage, this change still needs a test added to it. Could you please add one? It just needs to check if CircularProgressIndicator.adaptive with a value renders a CupertinoActivityIndicator with that same value.

[nikkivirtuoso]

yes i will add the test guide me

[nikkivirtuoso]

i have tried a code for testing here it is:
`import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';

void main() {
testWidgets('CircularProgressIndicator.adaptive test', (WidgetTester tester) async {
await tester.pumpWidget(
MaterialApp(
home: const Centre(
child: CircularProgressIndicator.adaptive(
value: 0.5,
),
),
),
);

expect(find.byType(CupertinoActivityIndicator), findsOneWidget);


expect(
  find.byType(CupertinoActivityIndicator).evaluate().first.widget.value,
  0.5,
);

});
}`

[MitchellGoodwin]

The test should be added in /packages/flutter/test/material/progress_indicator_test.dart. You can find a basic adaptive test on line 1065. What's important is the variant argument near the end. That will make the test only run on Apple platforms so the adaptive version goes to the Cupertino progress indicator. I believe the rest of your code will work.

[nikkivirtuoso]

@MitchellGoodwin, sir i have updated the test case as at first it was unable to extract the value hence i have taken the return type so that it don't get lost and all test cases have been passed, please review my code

[nikkivirtuoso]

@MitchellGoodwin Sir, please have a look

[MitchellGoodwin]

This test should be left alone. Instead, it would be better to add a new one. So you can copy the existing test as it was and put it below, then change it to look for the adaptive value logic. This makes it so that if either test fails in the future it will be easier to see what logic is broken.

Also, it would be better to try and get the value of progress of CupertinoActivityIndicator to check that the adaptive logic is working.

[nikkivirtuoso]

Sir i got the first part, but i am confused with the last part, you are saying that it should test on the value provided by the user not the default value that i have set to 0.5, am I right ?

[MitchellGoodwin]

You should test that if CircularProgressIndicator.adaptive is given a value of something, in this case 0.5, then a CupertinoActivityIndicator is rendered with a progress of 0.5.

[MitchellGoodwin]

Code looks good to me. Thank you for righting the test. I just have some formatting nits.

[MitchellGoodwin]

Nit: tab these lines to the left.

[MitchellGoodwin]

I updated the PR description with a link to the original issue, and put the checklist. I checked off what I could see was done. Check the top three if you've read those resources. If not, I would encourage you to look over them. This PR does not need documentation, so that can be left blank.

[nikkivirtuoso]

Yes sir, I have checked the top three resources, and i have read them, now i have understood the significance of trailing spaces, Thankyou Sir.

[nikkivirtuoso]

Sir, any suggestions for me its my first PR which is going to merge and i haven't entered the software industry yet i am trying to get a job

[nikkivirtuoso]

Sir, please review my code

[MitchellGoodwin]

I have two outstanding nits. Address those and this will be done, I think.

[jmagman]

sir please review my code

@nikkivirtuoso thank you so much for your contribution! But please refrain from pinging your PR, @MitchellGoodwin is in the process of reviewing it and has many things to do, in addition to reviewing this. Our contribution guide says:

If nobody has reviewed your code after a week, then reach out on our Chat channels. The #hackers-new channel is a good place to ask for help if you're a new contributor.

So if it's been more than a week, please reach out! Thanks again!

[MitchellGoodwin]

LGTM. Thank you for responding to all my feedback. The next step is to get a second approval. I'll ask around to see if I can get someone to take a look.

[QuncCccccc]

LGTM with some nits. Thanks a lot for the contribution:)!

[justinmc]

Thanks for fixing this bug! LGTM with some small style changes below.

[justinmc]

val should be value per the styleguide: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-abbreviations

Or just use the full widget.value directly.

[justinmc]

Space after the colon here.

[justinmc]

      final double actualProgress = tester.widget<CupertinoActivityIndicator>(
        find.byType(CupertinoActivityIndicator),
      ).progress;

[nikkivirtuoso]

sir please review my code

@nikkivirtuoso thank you so much for your contribution! But please refrain from pinging your PR, @MitchellGoodwin is in the process of reviewing it and has many things to do, in addition to reviewing this. Our contribution guide says:

If nobody has reviewed your code after a week, then reach out on our Chat channels. The #hackers-new channel is a good place to ask for help if you're a new contributor.

So if it's been more than a week, please reach out! Thanks again!

Thank you for the guidance! I appreciate your consideration and will refrain from further pings. I'll patiently wait for the review and, if needed, will follow up after a week. Thanks for your time and support!