Skip to content

[CP] Reland "Fixes ability to call nextFocus() on a node to focus its desc… #137630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[CP] Reland "Fixes ability to call nextFocus() on a node to focus its desc… #137630

wants to merge 2 commits into from

Conversation

CaseyHillers
Copy link
Contributor

#137071

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@chunhtai
Reland "Fixes ability to call nextFocus() on a node to focus its desc… (
cffa326 
flutter#136898)

�endant" (flutter#136894)"

This reverts commit c2bd2c1.

fixes flutter#134854

This is a straight reland, the internal test is testing a wrong behave. https://critique.corp.google.com/cl/575028981
@CaseyHillers CaseyHillers requested a review from chunhtai October 31, 2023 16:46
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: focus Focus traversal, gaining or losing focus labels Oct 31, 2023
@CaseyHillers CaseyHillers mentioned this pull request Oct 31, 2023
Closed
@CaseyHillers
Copy link
Contributor Author

@chunhtai feel free to reopen if this should be CP'd into the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

@chunhtai chunhtai Awaiting requested review from chunhtai

Assignees
No one assigned
Labels
f: focus Focus traversal, gaining or losing focus framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CaseyHillers @fluttergithubbot @chunhtai