Skip to content

Roll Flutter Engine from 6e09ee14e244 to 9486e6c5272a (2 revisions) #137187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Roll Flutter Engine from 6e09ee14e244 to 9486e6c5272a (2 revisions) #137187

wants to merge 2 commits into from

Conversation

engine-flutter-autoroll
Copy link
Contributor

flutter/engine@6e09ee1...9486e6c

2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from bc90585b0dd4 to 502277be15cf (1 revision) (flutter/engine#47277)
2023-10-24 1961493+harryterkelsen@users.noreply.github.com Reland "Use a single OffscreenCanvas for rendering in CanvasKit (#45744)" (flutter/engine#47241)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@engine-flutter-autoroll engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 24, 2023
@github-actions github-actions bot added the engine flutter/engine repository. See also e: labels. label Oct 24, 2023
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #137187 at sha 128613d

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Oct 24, 2023
@gaaclarke gaaclarke mentioned this pull request Oct 25, 2023
Open
@gaaclarke
Copy link
Member

I'm closing this pull on the suspicion that this is some sort of flake that we can then address separately. I've audited both PRs and they seem unrelated since one has to do with canvaskit and one just changes skia test files.

@gaaclarke gaaclarke closed this Oct 25, 2023
@engine-flutter-autoroll
Copy link
Contributor Author

Commit queue failed; closing this roll.

@engine-flutter-autoroll engine-flutter-autoroll deleted the flutter-engine-flutter-autoroll-931f7bbf-4e60-4808-b1ad-2f73f74e2c35-1698183034 branch October 31, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App engine flutter/engine repository. See also e: labels. will affect goldens Changes to golden files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engine-flutter-autoroll @gaaclarke @fluttergithubbot