Skip to content

Remove the 'Windows_arm64 plugin_test' Devicelab test #136379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2023
Merged

Remove the 'Windows_arm64 plugin_test' Devicelab test #136379

merged 1 commit into from
Oct 11, 2023

Conversation

@loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Oct 11, 2023

This removes the Windows_arm64 plugin_test as Devicelab tests aren't able to target Android from a Windows Arm64 host yet. I opened #136378 to track this work.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

yaakovschectman
yaakovschectman approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@yaakovschectman yaakovschectman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 11, 2023
@auto-submit auto-submit bot merged commit f2931db into flutter:master Oct 11, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
f2931db Remove the 'Windows_arm64 plugin_test' Devicelab test (flutte…
897012b 
…r/flutter#136379)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
f2931db Remove the 'Windows_arm64 plugin_test' Devicelab test (flutte…
1812557 
…r/flutter#136379)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
f2931db Remove the 'Windows_arm64 plugin_test' Devicelab test (flutte…
700d683 
…r/flutter#136379)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
f2931db Remove the 'Windows_arm64 plugin_test' Devicelab test (flutte…
56a0834 
…r/flutter#136379)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
f2931db Remove the 'Windows_arm64 plugin_test' Devicelab test (flutte…
f53dbcd 
…r/flutter#136379)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
f2931db Remove the 'Windows_arm64 plugin_test' Devicelab test (flutte…
32ba15c 
…r/flutter#136379)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
f2931db Remove the 'Windows_arm64 plugin_test' Devicelab test (flutte…
09721b7 
…r/flutter#136379)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2023
@engine-flutter-autoroll
f2931db Remove the 'Windows_arm64 plugin_test' Devicelab test (flutte…
1cdbd09 
…r/flutter#136379)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken Awaiting requested review from cbracken

1 more reviewer

@yaakovschectman yaakovschectman yaakovschectman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loic-sharma @yaakovschectman