Skip to content

[iOS,macOS] Clean up obsolete PlatformView warning #135040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2023
Merged

[iOS,macOS] Clean up obsolete PlatformView warning #135040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/flutter/lib/src/services/platform_views.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,11 +201,7 @@ class PlatformViewsService {
return controller;
}

// TODO(amirh): reference the iOS plugin API for registering a UIView factory
// once it lands.

/// This is work in progress, not yet ready to be used, and requires a custom
/// engine build. Creates a controller for a new iOS UIView.
/// Factory method to create a `UiKitView`.
///
/// The `id` parameter is an unused unique identifier generated with
/// [platformViewsRegistry].
Expand All @@ -218,6 +214,8 @@ class PlatformViewsService {
/// The `onFocus` parameter is a callback that will be invoked when the UIKit
/// view asks to get the input focus. If `creationParams` is non null then
/// `creationParamsCodec` must not be null.
///
/// See: https://docs.flutter.dev/platform-integration/ios/platform-views
static Future<UiKitViewController> initUiKitView({
required int id,
required String viewType,
Expand Down Expand Up @@ -249,6 +247,8 @@ class PlatformViewsService {
return UiKitViewController._(id, layoutDirection);
}

// TODO(cbracken): Write and link website docs. https://github.com/flutter/website/issues/9424.
//
/// Factory method to create an `AppKitView`.
///
/// The `id` parameter is an unused unique identifier generated with
Expand Down