Take paint offset into account for inline children hit test in Editable #131675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
tgucio
changed the title
github-actions
bot
added
the
framework
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 7, 2023
tarrinneal
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 7, 2023
flutter/flutter@2ba9f7b...ad0aa8d 2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from b10891e0d8d8 to 5b47c0577060 (1 revision) (flutter/flutter#132040) 2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4304d6180264 to b10891e0d8d8 (1 revision) (flutter/flutter#132037) 2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from eb91441398a1 to 4304d6180264 (1 revision) (flutter/flutter#132031) 2023-08-07 72562119+tgucio@users.noreply.github.com Constrain _RenderScaledInlineWidget child size in computeDryLayout (flutter/flutter#131765) 2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 15b5707af406 to eb91441398a1 (1 revision) (flutter/flutter#132025) 2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from a1d513f78bbb to 15b5707af406 (2 revisions) (flutter/flutter#132020) 2023-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from c9bd380ccbb0 to a1d513f78bbb (1 revision) (flutter/flutter#132015) 2023-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 060c95f94364 to c9bd380ccbb0 (1 revision) (flutter/flutter#132008) 2023-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from af7aaae2f1f9 to 060c95f94364 (1 revision) (flutter/flutter#132006) 2023-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from cdafc05a7217 to af7aaae2f1f9 (2 revisions) (flutter/flutter#132004) 2023-08-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from b512df490c94 to cdafc05a7217 (1 revision) (flutter/flutter#131996) 2023-08-05 72562119+tgucio@users.noreply.github.com Take paint offset into account for inline children hit test in Editable (flutter/flutter#131675) 2023-08-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from d26b8c8fb60c to b512df490c94 (1 revision) (flutter/flutter#131987) 2023-08-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2ce2913acbe4 to d26b8c8fb60c (1 revision) (flutter/flutter#131986) 2023-08-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 628b086265f2 to 2ce2913acbe4 (1 revision) (flutter/flutter#131983) 2023-08-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7302a678e58e to 628b086265f2 (1 revision) (flutter/flutter#131976) 2023-08-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 138a1ea9a692 to 7302a678e58e (2 revisions) (flutter/flutter#131975) 2023-08-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from a0d650e37f5d to 138a1ea9a692 (2 revisions) (flutter/flutter#131972) 2023-08-05 polinach@google.com Add TODO to refactor error handling. (flutter/flutter#131878) 2023-08-05 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 4f4734cd48da to a0d650e37f5d (3 revisions) (flutter/flutter#131967) 2023-08-05 32242716+ricardoamador@users.noreply.github.com Mark the ci_yaml roller task so that it is not backfilled. (flutter/flutter#131966) 2023-08-05 christopherfujino@gmail.com mark linux packages_autoroller flaky because of token issue (flutter/flutter#131970) 2023-08-04 30870216+gaaclarke@users.noreply.github.com Sped up the time to find macrobenchmarks. (flutter/flutter#131959) 2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from c254deb8fbda to 4f4734cd48da (2 revisions) (flutter/flutter#131955) 2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7bea8621f4b to c254deb8fbda (3 revisions) (flutter/flutter#131950) 2023-08-04 jmccandless@google.com Predictive back support for root routes (flutter/flutter#120385) 2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from e9f80bff0703 to a7bea8621f4b (3 revisions) (flutter/flutter#131948) 2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from badca1f7f8c9 to e9f80bff0703 (6 revisions) (flutter/flutter#131943) 2023-08-04 tessertaha@gmail.com Mention `showTimePicker` function be can be used to show dialog with the time picker in the `TimePickerDialog` docs (flutter/flutter#131932) 2023-08-04 15619084+vashworth@users.noreply.github.com Check for simulator runtime in flutter doctor (flutter/flutter#131795) 2023-08-04 engine-flutter-autoroll@skia.org Roll Packages from d00c1f9 to ce53da1 (3 revisions) (flutter/flutter#131935) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131669
Pre-launch Checklist
///).