fix(flutter_tools): `findBundleFile` w/multiple flavor dimensions #127133

felangel · 2023-05-18T19:36:44Z

Fixes the findBundleFile method in gradle.dart to correctly locate app bundles generated from multiple flavor dimensions.

closes flutter build doesn't work for appbundle with few flavor dimensions #92316
closes when building app bundle with multiple flavorDimension, tool cannot locate .aab file #65264

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

christopherfujino · 2023-05-18T21:24:03Z

FYI @reidbaker

christopherfujino

LGTM

nilsreichardt · 2023-05-19T08:00:56Z

@felangel Just as a note: This PR does not automatically close the linked issues

…ions (flutter/flutter#127133)

flutter/flutter@5ae6438...077d644 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2e6b1e6c3458 to a0ea4d2d9ea5 (1 revision) (flutter/flutter#127203) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from e9178e115f14 to 2e6b1e6c3458 (1 revision) (flutter/flutter#127196) 2023-05-19 felangelov@gmail.com fix(flutter_tools): `findBundleFile` w/multiple flavor dimensions (flutter/flutter#127133) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2e8875870f52 to e9178e115f14 (1 revision) (flutter/flutter#127188) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from c7a209cc40c1 to 2e8875870f52 (1 revision) (flutter/flutter#127185) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5a57ff52f0f7 to c7a209cc40c1 (2 revisions) (flutter/flutter#127175) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from bfbd2e1dafb0 to 5a57ff52f0f7 (1 revision) (flutter/flutter#127172) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from e64084596182 to bfbd2e1dafb0 (2 revisions) (flutter/flutter#127167) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6bc60c8a9877 to e64084596182 (2 revisions) (flutter/flutter#127163) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from bca11a423f9c to 6bc60c8a9877 (1 revision) (flutter/flutter#127162) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9039c2dfb74c to bca11a423f9c (2 revisions) (flutter/flutter#127156) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3c23ddae1d2a to 9039c2dfb74c (2 revisions) (flutter/flutter#127154) 2023-05-19 47866232+chunhtai@users.noreply.github.com Properly cleans up routes (flutter/flutter#126453) 2023-05-19 36861262+QuncCccccc@users.noreply.github.com Remove deprecated `primaryVariant` and `secondaryVariant` from `ColorScheme` (flutter/flutter#127124) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 17227c16ca58 to 3c23ddae1d2a (2 revisions) (flutter/flutter#127147) 2023-05-18 36861262+QuncCccccc@users.noreply.github.com Update `useMaterial3` api doc (flutter/flutter#127142) 2023-05-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from c7c679d6d411 to 17227c16ca58 (1 revision) (flutter/flutter#127143) 2023-05-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2c77c8011d45 to c7c679d6d411 (1 revision) (flutter/flutter#127139) 2023-05-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5fb3179a19c3 to 2c77c8011d45 (2 revisions) (flutter/flutter#127131) 2023-05-18 joshualitt@google.com Migrate benchmarks to package:web (flutter/flutter#126848) 2023-05-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 237c60185ace to 5fb3179a19c3 (3 revisions) (flutter/flutter#127126) 2023-05-18 53684884+mhbdev@users.noreply.github.com Fixing richMessage gesture recognizer in tooltip widget (flutter/flutter#126207) 2023-05-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 843ce0bba356 to 237c60185ace (2 revisions) (flutter/flutter#127122) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…utter#127133) Fixes the `findBundleFile` method in `gradle.dart` to correctly locate app bundles generated from multiple flavor dimensions. - closes flutter#92316 - closes flutter#65264

flutter/flutter@5ae6438...077d644 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2e6b1e6c3458 to a0ea4d2d9ea5 (1 revision) (flutter/flutter#127203) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from e9178e115f14 to 2e6b1e6c3458 (1 revision) (flutter/flutter#127196) 2023-05-19 felangelov@gmail.com fix(flutter_tools): `findBundleFile` w/multiple flavor dimensions (flutter/flutter#127133) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2e8875870f52 to e9178e115f14 (1 revision) (flutter/flutter#127188) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from c7a209cc40c1 to 2e8875870f52 (1 revision) (flutter/flutter#127185) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5a57ff52f0f7 to c7a209cc40c1 (2 revisions) (flutter/flutter#127175) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from bfbd2e1dafb0 to 5a57ff52f0f7 (1 revision) (flutter/flutter#127172) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from e64084596182 to bfbd2e1dafb0 (2 revisions) (flutter/flutter#127167) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6bc60c8a9877 to e64084596182 (2 revisions) (flutter/flutter#127163) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from bca11a423f9c to 6bc60c8a9877 (1 revision) (flutter/flutter#127162) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9039c2dfb74c to bca11a423f9c (2 revisions) (flutter/flutter#127156) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3c23ddae1d2a to 9039c2dfb74c (2 revisions) (flutter/flutter#127154) 2023-05-19 47866232+chunhtai@users.noreply.github.com Properly cleans up routes (flutter/flutter#126453) 2023-05-19 36861262+QuncCccccc@users.noreply.github.com Remove deprecated `primaryVariant` and `secondaryVariant` from `ColorScheme` (flutter/flutter#127124) 2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 17227c16ca58 to 3c23ddae1d2a (2 revisions) (flutter/flutter#127147) 2023-05-18 36861262+QuncCccccc@users.noreply.github.com Update `useMaterial3` api doc (flutter/flutter#127142) 2023-05-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from c7c679d6d411 to 17227c16ca58 (1 revision) (flutter/flutter#127143) 2023-05-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2c77c8011d45 to c7c679d6d411 (1 revision) (flutter/flutter#127139) 2023-05-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5fb3179a19c3 to 2c77c8011d45 (2 revisions) (flutter/flutter#127131) 2023-05-18 joshualitt@google.com Migrate benchmarks to package:web (flutter/flutter#126848) 2023-05-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 237c60185ace to 5fb3179a19c3 (3 revisions) (flutter/flutter#127126) 2023-05-18 53684884+mhbdev@users.noreply.github.com Fixing richMessage gesture recognizer in tooltip widget (flutter/flutter#126207) 2023-05-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 843ce0bba356 to 237c60185ace (2 revisions) (flutter/flutter#127122) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…ions (flutter/flutter#127133)

fix(flutter_tools): findBundleFile w/multi-dimensional flavors

5ad3d14

felangel added the tool Affects the "flutter" command-line tool. See also t: labels. label May 18, 2023

felangel self-assigned this May 18, 2023

felangel and others added 2 commits May 18, 2023 14:36

Merge branch 'master' into fix/appbundle-flavor-name

698d5bc

improve doc comment

e4437f0

felangel changed the title ~~fix(flutter_tools): findBundleFile w/multi-dimensional flavors~~ fix(flutter_tools): findBundleFile w/multiple flavor dimensions May 18, 2023

felangel mentioned this pull request May 18, 2023

fix: builds with multi dimension flavors are failing shorebirdtech/shorebird#515

Closed

felangel requested review from christopherfujino and jonahwilliams May 18, 2023 20:49

christopherfujino approved these changes May 18, 2023

View reviewed changes

christopherfujino requested a review from eliasyishak May 18, 2023 21:25

felangel added the autosubmit Merge PR when tree becomes green via auto submit App label May 19, 2023

auto-submit bot merged commit 3af7f9b into master May 19, 2023

auto-submit bot deleted the fix/appbundle-flavor-name branch May 19, 2023 15:00

engine-flutter-autoroll mentioned this pull request May 19, 2023

Roll Flutter from 5ae64381578c to 54ac355dc11f (22 revisions) flutter/packages#4042

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2023

3af7f9b fix(flutter_tools): findBundleFile w/multiple flavor dimens…

6b0b21d

…ions (flutter/flutter#127133)

engine-flutter-autoroll mentioned this pull request May 19, 2023

Roll Flutter from 5ae64381578c to 077d644bbc5f (23 revisions) flutter/packages#4043

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2023

3af7f9b fix(flutter_tools): findBundleFile w/multiple flavor dimens…

16dacc9

…ions (flutter/flutter#127133)

This was referenced May 25, 2023

Support minifcation for apps that depend on AGP 8 and integration_test #127628

Merged

i127682 android api 33 test support #127689

Merged

felangel mentioned this pull request Aug 1, 2023

fix(flutter_tools): findBundleFile w/multiple flavor dimensions shorebirdtech/flutter#16

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

3af7f9b fix(flutter_tools): findBundleFile w/multiple flavor dimens…

cabae9f

…ions (flutter/flutter#127133)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

3af7f9b fix(flutter_tools): findBundleFile w/multiple flavor dimens…

39f017b

…ions (flutter/flutter#127133)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

3af7f9b fix(flutter_tools): findBundleFile w/multiple flavor dimens…

652757d

…ions (flutter/flutter#127133)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

3af7f9b fix(flutter_tools): findBundleFile w/multiple flavor dimens…

4e3f100

…ions (flutter/flutter#127133)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(flutter_tools): `findBundleFile` w/multiple flavor dimensions #127133

fix(flutter_tools): `findBundleFile` w/multiple flavor dimensions #127133

Uh oh!

felangel commented May 18, 2023 •

edited

Loading

Uh oh!

christopherfujino commented May 18, 2023

Uh oh!

christopherfujino left a comment

Uh oh!

nilsreichardt commented May 19, 2023

Uh oh!

Uh oh!

fix(flutter_tools): findBundleFile w/multiple flavor dimensions #127133

fix(flutter_tools): findBundleFile w/multiple flavor dimensions #127133

Uh oh!

Conversation

felangel commented May 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

christopherfujino commented May 18, 2023

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

nilsreichardt commented May 19, 2023

Uh oh!

Uh oh!

fix(flutter_tools): `findBundleFile` w/multiple flavor dimensions #127133

fix(flutter_tools): `findBundleFile` w/multiple flavor dimensions #127133

felangel commented May 18, 2023 •

edited

Loading