Skip to content

Roll Flutter Engine from 7572fe5b9226 to 9270e3de510e (1 revision) #122438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

engine-flutter-autoroll
Copy link
Contributor

flutter/engine@7572fe5...9270e3d

2023-03-10 31859944+LongCatIsLooong@users.noreply.github.com Make FlutterTest the default test font (flutter/engine#40188)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@engine-flutter-autoroll engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 10, 2023

auto label is removed for flutter/flutter, pr: 122438, due to - The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@engine-flutter-autoroll
Copy link
Contributor Author

Commit queue failed; closing this roll.

@DanTup
Copy link
Contributor

DanTup commented Mar 13, 2023

@LongCatIsLooong I've regenerated goldens for Tiler using this version, the correct hash is 0f80585f1f7d9a01a463c316e44c59b3cc86f9f0

Please review the differences listed here to ensure they're what you expect - the changes are fairly subtle (for ex. some lines being slightly lighter/thinner) and I'm not familiar with the change that was made and what difference was expected.

DanTup/tiler@0f80585

@engine-flutter-autoroll engine-flutter-autoroll deleted the flutter-engine-flutter-autoroll-e692cb96-c014-4312-a3ec-5a0399e9ae92-1678490173 branch March 17, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants