Utility methods for measuring text #111493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: text input
dnfield
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter, pr: 111493, due to - The status or check suite Linux web_long_running_tests_5_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
dnfield
added
the
autosubmit
| static double computeWidth({ | ||
| required InlineSpan text, | ||
| TextAlign textAlign = TextAlign.start, | ||
| TextDirection? textDirection, |
Contributor
There was a problem hiding this comment.
TextDirection must be non null I think?
Contributor
Author
There was a problem hiding this comment.
This was copied from the TextPainter ctor. I'd like to keep the types the same for ease of migration.
If we want to update this we should update the ctor as well.
Contributor
Author
There was a problem hiding this comment.
Ahh but I see what you're saying, on the regular object we can set this to some value later, whereas we can't with this method. Ok. In that case, I'll file a follow upt o make it non-nullable.
This was referenced Sep 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
TextPainters must be disposed, it makes some sense to wrap this functionality in a utility method.In customer applications, it is very common to use a text painter to figure out the width of something you want to animate, and then immediately dispose of the painter. This is probably ok because of caching that SkParagraph will do.
I'm a little bit on the fence about whether we should be promoting this, but there are at least 100 callsites in Google's monorepo that use this pattern (likely with some cargo-culting since the code is basically the same everywhere) - so if there's some better way I'm open to hearing about it :)