Repository navigation
infra recipes need to install the cmdline-tools component of the Android SDK #82565
Description
Activity
I guess this must be updated on cirrus as well
This is already document in our install requirements here: https://flutter.dev/docs/get-started/install/windows#install-android-studio
@jonahwilliams Can you please share the
sdkmanagercommand with version if applicable?We don't require any particular version. probably
latestis what you want to pull in- added a commit that references this issue
on May 15, 2021 @jonahwilliams can you please take a look to see if flutter doctor now passes correctly on Cirrus?
I'm still creating the bundles for LUCI
Will do, thank you @godofredoc
@jonahwilliams LUCI recipes have already been installing tools;1.0 which contains the same tools as cmdline-tools;4.0 I wonder if fixing the issue with the license for android-30 also fixed this issue. Is there a pending PR that I can validate with?
Additionally cmdline-tools changes the location of the binaries from <android_sdk_root >/tools to <android_sdk_root>/cmdline-tools/tools that may require some changes in the flutter tool if the relative path to those binaries is hardcoded.
i believe there are some places in devicelab where the test scripts poke into the android sdk directly, but the tool already handles looking in either cmdline-tools or tools.
#82560 adds the doctor check and removes a fallback for the old tools, you can use that to verify
It might be easier to leave the old tools component around until all of the devicelab tests are updated
@jonahwilliams the task using #82560 passed but I'm not sure how to validate it is using the new cmdline-tools. Would you mind taking a look? https://chromium-swarm.appspot.com/task?id=53a5dcf88237c110
If the doctor check passed then it found the tools it needed to find.
Test on your PR are now passing.
Excellent!
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.- locked as resolved and limited conversation to collaborators
on Aug 1, 2021
https://flutter.googlesource.com/recipes/+/refs/heads/master/recipe_modules/android_sdk/api.py
Newer version of Android Studio do not ship with a JDK that can run the old platform-tools sdk manager. In order for the tool to be able to switch, the infra needs to add this component so that the doctor health checks pass.
Blocking #82560 , #80273