Skip to content

flutter/packages should enforce an expected clang-format version #39767

Open
@mklim

Description

@mklim

Right now our formatting tools use whatever version of clang-format is in the user's path, but CI always uses clang-format-7. Apparently this has also changed over time, since looking at the related issue #12864 there's some mention of CI using clang-format-5. Formatting differences from clang-format version mismatches are hard to diagnose and can even be introduced just from running the formatting tool without any arguments. Ideally pub global run flutter_plugin_tools format should know what clang-format version CI is expecting and either download it itself (ideal) or throw if it can't find it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: contributor-productivityTeam-specific productivity, code health, technical debt.p: toolingAffects the flutter_plugin_tools packagepackageflutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions