several new analysis issues with the lastest dart sdk

[devoncarew]

The missing_return hint is stricter now - which is good - but does generate many new analysis issues in the flutter repo. We'll need to fix these before landing the next dart sdk, or revert the missing_return improvement.

warning • This function has a return type of 'String', but doesn't end with a return statement • dev/tools/gen_date_localizations.dart:58:15
warning • This function has a return type of 'StatelessWidget', but doesn't end with a return statement • examples/flutter_gallery/lib/demo/cupertino/cupertino_navigation_demo.dart:75:24
warning • This function has a return type of 'Tab', but doesn't end with a return statement • examples/flutter_gallery/lib/demo/material/scrollable_tabs_demo.dart:158:31
warning • This function has a return type of 'Future<Future<Null>>', but doesn't end with a return statement • examples/flutter_gallery/test_driver/transitions_perf_test.dart:159:54
warning • This function has a return type of 'Future<Null>', but doesn't end with a return statement • examples/layers/test/sector_test.dart:15:31
warning • This function has a return type of 'Future<Null>', but doesn't end with a return statement • examples/layers/test/smoketests/lib/main_test.dart:9:53
warning • This function has a return type of 'Future<Null>', but doesn't end with a return statement • examples/layers/test/smoketests/services/isolate_test.dart:10:61
warning • This function has a return type of 'Future<Null>', but doesn't end with a return statement • examples/layers/test/smoketests/services/lifecycle_test.dart:10:63
warning • This function has a return type of 'Future<Null>', but doesn't end with a return statement • examples/layers/test/smoketests/widgets/custom_render_box_test.dart:10:70
warning • This function has a return type of 'Future<Null>', but doesn't end with a return statement • examples/layers/test/smoketests/widgets/gestures_test.dart:10:61
warning • This function has a return type of 'Future<Null>', but doesn't end with a return statement • examples/layers/test/smoketests/widgets/hello_world_test.dart:10:64
warning • This function has a return type of 'Future<Null>', but doesn't end with a return statement • examples/layers/test/smoketests/widgets/media_query_test.dart:10:64
warning • This function has a return type of 'Future<Null>', but doesn't end with a return statement • examples/layers/test/smoketests/widgets/sectors_test.dart:10:60
warning • This function has a return type of 'Future<Null>', but doesn't end with a return statement • examples/layers/test/smoketests/widgets/spinning_square_test.dart:10:68
warning • This function has a return type of 'Future<Null>', but doesn't end with a return statement • examples/layers/test/smoketests/widgets/styled_text_test.dart:10:64
warning • This function has a return type of 'Future<ByteData>', but doesn't end with a return statement • packages/flutter/lib/src/services/platform_channel.dart:406:46
warning • This function has a return type of 'bool', but doesn't end with a return statement • packages/flutter/lib/src/widgets/heroes.dart:322:12
warning • This function has a return type of 'CupertinoPageRoute<void>', but doesn't end with a return statement • packages/flutter/test/cupertino/tab_test.dart:65:28
warning • This function has a return type of 'Route', but doesn't end with a return statement • packages/flutter/test/cupertino/tab_test.dart:87:27
warning • This function has a return type of 'Future<Null>', but doesn't end with a return statement • packages/flutter/test/gestures/debug_test.dart:10:52
warning • This function has a return type of 'Future<Null>', but doesn't end with a return statement • packages/flutter/test/gestures/debug_test.dart:56:53
warning • This function has a return type of 'Future<Null>', but doesn't end with a return statement • packages/flutter/test/gestures/debug_test.dart:98:91
warning • This function has a return type of 'Route', but doesn't end with a return statement • packages/flutter/test/material/app_test.dart:369:26
warning • This function has a return type of 'Route', but doesn't end with a return statement • packages/flutter/test/material/app_test.dart:372:25
warning • This function has a return type of 'Future', but doesn't end with a return statement • packages/flutter/test/material/checkbox_test.dart:253:56
warning • This function has a return type of 'Future', but doesn't end with a return statement • packages/flutter/test/material/feedback_test.dart:32:58
warning • This function has a return type of 'Future', but doesn't end with a return statement • packages/flutter/test/material/feedback_tester.dart:13:54
warning • This function has a return type of 'Future', but doesn't end with a return statement • packages/flutter/test/material/radio_test.dart:219:56
warning • This function has a return type of 'Future<void>', but doesn't end with a return statement • packages/flutter/test/material/refresh_indicator_test.dart:359:22
warning • This function has a return type of 'Future', but doesn't end with a return statement • packages/flutter/test/material/switch_test.dart:277:56
warning • This function has a return type of 'Future', but doesn't end with a return statement • packages/flutter/test/material/switch_test.dart:321:56
warning • This function has a return type of 'Future', but doesn't end with a return statement • packages/flutter/test/material/tooltip_test.dart:682:56
warning • This function has a return type of 'Future<ByteData>', but doesn't end with a return statement • packages/flutter/test/services/platform_messages_test.dart:14:51
warning • This function has a return type of 'bool', but doesn't end with a return statement • packages/flutter/test/widgets/dispose_ancestor_lookup_test.dart:101:39
warning • This function has a return type of 'Future', but doesn't end with a return statement • packages/flutter/test/widgets/editable_text_test.dart:732:55
warning • This function has a return type of 'bool', but doesn't end with a return statement • packages/flutter/test/widgets/list_wheel_scroll_view_test.dart:812:29
warning • This function has a return type of 'bool', but doesn't end with a return statement • packages/flutter/test/widgets/list_wheel_scroll_view_test.dart:863:29
warning • This function has a return type of 'MaterialPageRoute<void>', but doesn't end with a return statement • packages/flutter/test/widgets/navigator_test.dart:205:34
warning • This function has a return type of 'bool', but doesn't end with a return statement • packages/flutter/test/widgets/notification_test.dart:67:23
warning • This function has a return type of 'bool', but doesn't end with a return statement • packages/flutter/test/widgets/notification_test.dart:71:25
warning • This function has a return type of 'TestRoute<Null>', but doesn't end with a return statement • packages/flutter/test/widgets/page_forward_transitions_test.dart:81:26
warning • This function has a return type of 'TestRoute<Null>', but doesn't end with a return statement • packages/flutter/test/widgets/page_forward_transitions_test.dart:190:26
warning • This function has a return type of 'TextEditingValue', but doesn't end with a return statement • packages/flutter/test/widgets/text_formatter_test.dart:21:7
warning • This function has a return type of 'Future', but doesn't end with a return statement • packages/flutter_driver/test/flutter_driver_test.dart:283:60
warning • This function has a return type of 'Future', but doesn't end with a return statement • packages/flutter_driver/test/flutter_driver_test.dart:297:60
warning • This function has a return type of 'Future', but doesn't end with a return statement • packages/flutter_driver/test/flutter_driver_test.dart:340:60
warning • This function has a return type of 'Future<String>', but doesn't end with a return statement • packages/flutter_driver/test/src/extension_test.dart:77:46
warning • This function has a return type of 'Future<String>', but doesn't end with a return statement • packages/flutter_test/lib/src/matchers.dart:1437:37
warning • This function has a return type of 'Future<String>', but doesn't end with a return statement • packages/flutter_test/test/widget_tester_test.dart:503:40
warning • This function has a return type of 'FutureOr<List<int>>', but doesn't end with a return statement • packages/flutter_tools/test/compile_test.dart:372:25
warning • This function has a return type of 'Future<Null>', but doesn't end with a return statement • packages/flutter_tools/test/project_test.dart:16:36
warning • This function has a return type of 'Future<FlutterCommandResult>', but doesn't end with a return statement • packages/flutter_tools/test/runner/flutter_command_test.dart:129:52
warning • This function has a return type of 'Future<Null>', but doesn't end with a return statement • packages/flutter_tools/test/utils_test.dart:132:27
warning • This function has a return type of 'Future<Null>', but doesn't end with a return statement • packages/flutter_tools/test/utils_test.dart:143:27

54 issues found. (ran in 7.6s)

[leafpetersen]

Consider removing this line from analysis_options.yaml for now?

# treat missing returns as a warning (not a hint)
missing_return: warning

And then re-add it after they've fixed up?

[devoncarew]

That sounds reasonable (though, I can't remember if the build also breaks on a hint-level issue; if so, we'd want to move to just breaking on warnings for a short period of time).

[aartbik]

The following pending PR on flutter/flutter (1) contains Dart SDK engine roll and (2) changes "warning" into "ignore" (needed in two yaml files).

#20120

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.