Skip to content

[Decoupling] Unskip all skipped tests in material_ui and cupertino_ui #188395

Closed
Closed
[Decoupling] Unskip all skipped tests in material_ui and cupertino_ui#188395
Labels
P1High-priority issues at the top of the work lista: tests"flutter test", flutter_test, or one of our testsframeworkflutter/packages/flutter repository. See also f: labels.p: cupertino_uicupertino_ui package in flutter/packagesp: material_uimaterial_ui package in flutter/packagesteam-frameworkOwned by Framework teamtriaged-frameworkTriaged by Framework team

Description

@justinmc
justinmc
opened on Jun 23, 2026

Currently, many tests that were previously enabled in flutter/flutter are skipped in material_ui and cupertino_ui. We should re-enable these tests before releasing 1.0.0 of these new packages.

Why were the tests skipped?

The tests were skipped because they contain cross-imports, i.e. a test imports something that is not available in flutter/packages. These tests do no compile in flutter/packages, so they have been skipped with an @Skip annotation and placed into a temporarily_disabled_tests directory to avoid analysis.

What should we do about it?

The cross imports should be fixed according to #177028 and its sub-issues, and then the @Skip annotation should be removed and the test should be moved into the test directory.

Resources

Umbrella issue: #177028

Activity

  1. justinmc
    added this to Decoupling Designon Jun 23, 2026
  2. auto-submit
    added a commit that references this issue on Jun 23, 2026

    [Decoupling] Port PR (#186667) from flutter/flutter to material_ui an…

    c37e11b
  3. puneetkukreja98
    added
    frameworkflutter/packages/flutter repository. See also f: labels.
    p: material_uimaterial_ui package in flutter/packages
    p: cupertino_uicupertino_ui package in flutter/packages
    team-frameworkOwned by Framework team
    a: tests"flutter test", flutter_test, or one of our tests
    on Jun 24, 2026
  4. auto-submit
    added 8 commits that reference this issue on Jun 25, 2026

    [material_ui] Remove widgets import in `navigation_rail_test.dart` (#…

    9056267

    [material_ui] Remove widgets import in `drawer_test.dart` (#11976)

    80f66ae

    [material_ui] Remove widgets import in `slider_test.dart` (#11977)

    a76907c

    [material_ui] Remove widgets import in `scaffold_test.dart` (#11973)

    b762514

    [material_ui] Remove widgets import in `menu_anchor_test.dart` (#11995)

    b79468e

    [material_ui] Remove widgets import in `search_anchor_test.dart` (#11997

    241dba9

    [material_ui] Remove widgets import in `app_bar_test.dart` (#11998)

    f588865

    [material_ui] Remove widgets import in `animated_icon_test.dart` and …

    4bea773

  5. 32 remaining items

  6. justinmc
    added
    P1High-priority issues at the top of the work list
    triaged-frameworkTriaged by Framework team
    on Jun 30, 2026
  7. auto-submit
    added 8 commits that reference this issue on Jun 30, 2026

    [material_ui] Enable `time_picker_test` (#12061)

    862cdc5

    [cupertino_ui] Re-enable `text_field_test.dart` (#12067)

    7a9c621

    [cupertino_ui] Migrate `segmented_control_test.dart` to `SemanticsHan…

    99a427a

    [cupertino_ui] Migrate `nav_bar_test.dart` to `SemanticsHandle` (#11980)

    b791212

    [cupertino_ui] Migrate `route_test.dart` to `SemanticsHandle` (#11993)

    b791d2a

    [cupertino_ui] Migrate `sliding_segmented_control_test.dart` to `Sema…

    635f720

    [cupertino_ui] Migrate `bottom_tab_bar_test.dart` to `SemanticsHandle` (

    f4b7893

    [cupertino_ui] Enable `switch_test.dart` (#12076)

    0fc62ee

  8. justinmc commented on Jul 1, 2026

    @justinmc
    justinmc
    on Jul 1, 2026
    ContributorAuthor

    The temporarily_disabled_tests directories have been cleared out and deleted, this can be closed 🎉

  9. justinmc
    closed this as completedon Jul 1, 2026
  10. github-project-automation
    moved this to Done in Decoupling Designon Jul 1, 2026

  11. github-actions commented on Jul 15, 2026

    @github-actions
    github-actionsbot
    on Jul 15, 2026 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  12. github-actions
    locked as resolved and limited conversation to collaborators on Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1High-priority issues at the top of the work lista: tests"flutter test", flutter_test, or one of our testsframeworkflutter/packages/flutter repository. See also f: labels.p: cupertino_uicupertino_ui package in flutter/packagesp: material_uimaterial_ui package in flutter/packagesteam-frameworkOwned by Framework teamtriaged-frameworkTriaged by Framework team

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions