Remove usage of deprecated Notification.setListener(..) #8317
+15
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: cleanup of nullability parameters in FlutterMessages.java
helin24
approved these changes
Jul 8, 2025
| Notifications.Bus.notify( | ||
| new Notification( | ||
| FLUTTER_NOTIFICATION_GROUP_ID, | ||
| title, | ||
| message, | ||
| NotificationType.WARNING).setListener(NotificationListener.URL_OPENING_LISTENER), project); |
There was a problem hiding this comment.
Is a listener already set for this without using the deprecated fn? Or are we deciding to not listen for URL opens?
There was a problem hiding this comment.
Ack, I didn't see any negative effects on the core UX here of a user being exposed to the notification. If there is some piece I am missing we can prioritize and implement with non-deprecated APIs.
|
good job bro. But U're sure this simple delete have not bad effect on the code by the way ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: cleanup of nullability parameters in
FlutterMessages.java