Skip to content

[CQ] limit internal XDebugSessionImpl dependence; remove dead code #8206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pq
Copy link
Contributor

@pq pq commented May 20, 2025

🤫 Limits XDebugSessionImpl dependence (silencing two internal API access inspections); adding a note explaining our usage
🧹 Removes VmServiceWrapper dead code


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@pq pq requested a review from jwren May 20, 2025 18:20
Copy link
Member

@jwren jwren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, but do test to validate that this code works back to the Dart 3.0 debugger (and associated Flutter SDK)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants